mirror of
https://github.com/PHIDIAS0303/ExpCluster.git
synced 2026-08-13 00:45:11 +09:00
bbassieandClaude Opus 5
fd38816ff6
`fmtk luals-addon <outdir>` treats its argument as the parent and always appends `factorio`, so the bundle landed in `$RUNNER_TEMP/factorio/factorio` while the config pointed at `$RUNNER_TEMP/factorio/library`. The factorio types were never loaded, which is why ci reported 642 undefined-global and 1204 type-not-found against a tree that is clean locally. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
95 lines
3.7 KiB
YAML
95 lines
3.7 KiB
YAML
name: Lua Lint
|
|
|
|
on:
|
|
push:
|
|
pull_request:
|
|
|
|
env:
|
|
EMMYLUA_CHECK_VERSION: "0.24.0"
|
|
CLUSTERIO: ${{ github.workspace }}/.clusterio
|
|
|
|
jobs:
|
|
lint:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
- name: Checkout clusterio modules
|
|
uses: actions/checkout@v4
|
|
with:
|
|
repository: clusterio/clusterio
|
|
path: .clusterio
|
|
sparse-checkout: packages/host/modules
|
|
sparse-checkout-cone-mode: false
|
|
- uses: pnpm/action-setup@v4
|
|
with:
|
|
version: 10
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version: lts/*
|
|
- name: Generate Factorio typedefs
|
|
run: |
|
|
pnpm install factoriomod-debug
|
|
pnpm exec fmtk luals-addon "$RUNNER_TEMP"
|
|
- name: Install emmylua_check
|
|
run: |
|
|
curl -fsSL "https://github.com/EmmyLuaLs/emmylua-analyzer-rust/releases/download/${EMMYLUA_CHECK_VERSION}/emmylua_check-linux-x64.tar.gz" \
|
|
| tar -xz -C "$RUNNER_TEMP"
|
|
- name: Run Lint Report
|
|
shell: bash
|
|
run: |
|
|
# The typedefs are generated per run, clusterio comes from CLUSTERIO above
|
|
jq -n --arg lib "$RUNNER_TEMP/factorio/library" \
|
|
'{ workspace: { library: [ $lib ], ignoreGlobs: [ ".clusterio/**" ] } }' \
|
|
> "$RUNNER_TEMP/ci.emmyrc.json"
|
|
|
|
# Exits non zero on error severity, so the gate below is used instead
|
|
"$RUNNER_TEMP/emmylua_check" . --config ".emmyrc.json,$RUNNER_TEMP/ci.emmyrc.json" \
|
|
--output-format json --output check.json || true
|
|
|
|
# Credit to https://github.com/Krealle/luals-check-action/blob/main/action.yml
|
|
# Although some minor fixes were needed
|
|
|
|
# Format and print the messages (would be nice to format as a table, but that's too complex for jq)
|
|
jq -r --arg root "$PWD/" \
|
|
'.[] | (.file | ltrimstr($root)) as $file | .diagnostics[] |
|
|
{
|
|
file: $file,
|
|
code: .code,
|
|
line: .range.start.line,
|
|
message: (.message | split("\n")
|
|
| map(if startswith("- ") then .[2:] else . end)
|
|
| join("\n")),
|
|
severity: (if .severity <= 1 then "ERR" else "WARN" end)
|
|
} |
|
|
"**[\(.severity)] \(.code):** \(.file)#L\(.line + 1)<br><code>\(.message)</code>"' \
|
|
check.json > "$GITHUB_STEP_SUMMARY"
|
|
|
|
echo ""
|
|
|
|
# Github Annotations (limited to 10)
|
|
jq -r --arg root "$PWD/" \
|
|
'.[] | (.file | ltrimstr($root)) as $file | .diagnostics[] |
|
|
{
|
|
file: $file,
|
|
title: .code,
|
|
line: .range.start.line,
|
|
endLine: .range.end.line,
|
|
col: .range.start.character,
|
|
endColumn: .range.end.character,
|
|
message: (.message | gsub("\n"; "%0A"; "m")),
|
|
level: (if .severity <= 1 then "error" else "warning" end)
|
|
} |
|
|
"::\(.level) file=\(.file),line=\(.line + 1),endLine=\(.endLine + 1),col=\(.col + 1),endColumn=\(.endColumn + 1),title=\(.title)::\(.message) (\(.title))"' \
|
|
check.json
|
|
|
|
# An entry is emitted for every file checked, including clean ones, so
|
|
# the gate counts diagnostics and asserts the workspace was actually read
|
|
if [[ $(jq 'length' check.json) -lt 100 ]] ; then
|
|
echo "::error::Only $(jq 'length' check.json) files were checked, expected the whole workspace"
|
|
exit 1
|
|
elif [[ $(jq '[.[].diagnostics[]] | length' check.json) -gt 0 ]] ; then
|
|
exit 1
|
|
else
|
|
echo "✅ All checks succeeded!" | tee "$GITHUB_STEP_SUMMARY"
|
|
fi
|