Use new linter (#294)

* Use new linter

* Luacheck and Sumneko Lua fixes

* Bump CI action versions

* Fix excludes for ldoc

modules/control/jail.lua

@@ -83,12 +83,12 @@ function Jail.jail_player(player, by_player_name, reason)
     if has_role(player, 'Jail') then return end
     local roles = get_roles(player)
 
-    player.walking_state = { walking = false }
+    player.walking_state = { walking = false, direction = player.walking_state.direction }
     player.riding_state = { acceleration = defines.riding.acceleration.nothing, direction = player.riding_state.direction }
     player.mining_state = { mining = false }
-    player.shooting_state = { state = defines.shooting.not_shooting }
+    player.shooting_state = { state = defines.shooting.not_shooting, position = player.shooting_state.position }
     player.picking_state = false
-    player.repair_state = { repairing = false }
+    player.repair_state = { repairing = false, position = player.repair_state.position }
 
     unassign_roles(player, roles, by_player_name, nil, true)
     assign_roles(player, 'Jail', by_player_name, nil, true)

modules/control/selection.lua

@@ -129,7 +129,7 @@ function Selection.on_selection(selection_name, handler)
     Event.add(defines.events.on_player_selected_area, function(event)
         local selection = selections[event.player_index]
         if not selection or selection.name ~= selection_name then return end
-        handler(event, unpack(selection.arguments))
+        handler(event, table.unpack(selection.arguments))
     end)
 end
 
@@ -140,13 +140,13 @@ function Selection.on_alt_selection(selection_name, handler)
     Event.add(defines.events.on_player_alt_selected_area, function(event)
         local selection = selections[event.player_index]
         if not selection or selection.name ~= selection_name then return end
-        handler(event, unpack(selection.arguments))
+        handler(event, table.unpack(selection.arguments))
     end)
 end
 
 --- Stop selection if the selection tool is removed from the cursor
 Event.add(defines.events.on_player_cursor_stack_changed, function(event)
-    local player = game.get_player(event.player_index)
+    local player = game.get_player(event.player_index) ---@cast player -nil
     if player.cursor_stack.is_selection_tool then return end
     Selection.stop(player)
 end)

modules/control/warps.lua

@@ -33,6 +33,7 @@ local Warps = {}
 
 -- Global lookup table for force name to task ids
 local force_warps = {_uid=1}
+---@cast force_warps table<string, { spawn: string, [number]: string }>
 Global.register(force_warps, function(tbl)
     force_warps = tbl
 end)