mirror of
https://github.com/PHIDIAS0303/ExpCluster.git
synced 2026-09-21 17:04:00 +00:00
Move the scenario onto exp_roles and remove the legacy role system
Every call site of expcore.roles now uses exp_roles, and the legacy module, its config, and the glue which refreshed guis on role events are deleted. Where a file only renamed the require and the permission strings the change is mechanical; the rest: - Jail is now "give the Jail role" and unjail "take it away". The role has a higher priority than every other so holding it suppresses them, which is what stashing and restoring the roles was for. - The command role authority derives exp_scenario.command.<name> from the command name, and the role parsers use player_outranks rather than comparing indexes with their own root check. - The admin and spectator triggers, and the gui refresh on role changes, live in exp_scenario/control/roles.lua; the system commands trigger stays with the command authority. - The player list warn button is keyed on create_warning, the permission the command behind it already required, and report on create_report. Both were keyed on names no role held, so only root ever saw them. - The warps and tasks configs say exp_roles where they said expcore.roles. - The role tables the readme and player list read are replaced by get_player_names and get_roles. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Fable 5
parent
eb715cc176
commit
7034f17b5d
@@ -6,8 +6,8 @@ local Commands = require("modules/exp_commands")
|
||||
local format_player_name = Commands.format_player_name_locale
|
||||
local format_text = Commands.format_rich_text_color_locale
|
||||
|
||||
local Roles = require("modules.exp_legacy.expcore.roles") --- @dep expcore.roles
|
||||
local get_roles_ordered = Roles.get_roles_ordered
|
||||
local Roles = require("modules/exp_roles")
|
||||
local get_roles = Roles.get_roles
|
||||
local get_player_roles = Roles.get_player_roles
|
||||
|
||||
--- Assigns a role to a player
|
||||
@@ -18,7 +18,7 @@ Commands.new("assign-role", { "exp-commands_roles.description-assign" })
|
||||
:add_flags{ "admin_only" }
|
||||
:register(function(player, other_player, role)
|
||||
--- @cast other_player LuaPlayer
|
||||
--- @cast role any -- TODO
|
||||
--- @cast role ExpRoles.Role
|
||||
Roles.assign_player(other_player, role, player.name)
|
||||
end)
|
||||
|
||||
@@ -30,7 +30,7 @@ Commands.new("unassign-role", { "exp-commands_roles.description-unassign" })
|
||||
:add_flags{ "admin_only" }
|
||||
:register(function(player, other_player, role)
|
||||
--- @cast other_player LuaPlayer
|
||||
--- @cast role any -- TODO
|
||||
--- @cast role ExpRoles.Role
|
||||
Roles.unassign_player(other_player, role, player.name)
|
||||
end)
|
||||
|
||||
@@ -40,7 +40,7 @@ Commands.new("get-roles", { "exp-commands_roles.description-get" })
|
||||
:add_aliases{ "roles" }
|
||||
:register(function(player, other_player)
|
||||
--- @cast other_player LuaPlayer?
|
||||
local roles = get_roles_ordered()
|
||||
local roles = get_roles()
|
||||
local roles_formatted = { "" } --- @type LocalisedString
|
||||
local response = { "exp-commands_roles.list-roles", roles_formatted } --[[@as LocalisedString]]
|
||||
if other_player then
|
||||
@@ -50,7 +50,7 @@ Commands.new("get-roles", { "exp-commands_roles.description-get" })
|
||||
end
|
||||
|
||||
for index, role in ipairs(roles) do
|
||||
local role_name = format_text(role.name, role.custom_color or Commands.color.white)
|
||||
local role_name = format_text(role.name, role.color or Commands.color.white)
|
||||
roles_formatted[index + 1] = { "exp-commands_roles.list-element", role_name }
|
||||
end
|
||||
|
||||
|
||||
Reference in New Issue
Block a user