aperx/factorio-scenario-ExpCluster
1
0
Fork 0
mirror of https://github.com/PHIDIAS0303/ExpCluster.git synced 2026-09-23 01:34:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address final review nits on the assertions

Browse Source 
- Suite.empty(value, name) checks a table has no entries and reports what it
  held, and Suite.throws(fn, message, name) asserts a function errors with the
  given message, so an unrelated error no longer passes as the expected one.
- Scalar comparisons and zero length checks go through eq and empty, and the
  announced messages and print output are compared by content, so a failure
  shows the actual data.
- get_roles() is asserted through sorted names rather than a count.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
bbassie
2026-08-26 10:48:43 +00:00
co-authored by Claude Fable 5
parent 3218351db6
commit 574a0a4b52
6 changed files with 73 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
exp_roles/test/lua/lookup.lua
+8 -6
View File
@@ -5,18 +5,20 @@ local test, check, eq = Suite.test, Suite.check, Suite.eq
test("get_role() returns the role with the given clusterio id", function(env)
env.initialise{}
check(env.Roles.get_role(env.R("Regular").id) == env.R("Regular"), "the role is found by id")
check(env.Roles.get_role(9) == nil, "deleted roles are not known")
eq(env.Roles.get_role(9), nil, "deleted roles are not known")
end)
test("get_role_by_name() searches the roles", function(env)
env.initialise{}
check(env.Roles.get_role_by_name("Moderator") == env.R("Moderator"), "the role is found by name")
check(env.Roles.get_role_by_name("Gone") == nil, "deleted roles are not known")
eq(env.Roles.get_role_by_name("Gone"), nil, "deleted roles are not known")
end)
test("get_roles() returns every role", function(env)
env.initialise{}
check(#env.Roles.get_roles() == 5, "every role is returned with deleted roles skipped")
eq(Suite.sorted(Suite.names(env.Roles.get_roles())),
{ "Cluster Admin", "Jail", "Moderator", "Player", "Regular" },
"every role is returned with deleted roles skipped")
end)
test("get_ordered_roles() returns the most privileged first", function(env)
@@ -60,9 +62,9 @@ end)
test("initialise() decodes the role records", function(env)
env.initialise{}
check(env.R("Cluster Admin").short_hand == "SYS", "short hand decoded")
check(env.R("Moderator").short_hand == "Moderator", "short hand falls back to the name")
check(env.R("Moderator").color.g == 170, "color decoded")
eq(env.R("Cluster Admin").short_hand, "SYS", "short hand decoded")
eq(env.R("Moderator").short_hand, "Moderator", "short hand falls back to the name")
eq(env.R("Moderator").color, { r = 0, g = 170, b = 0 }, "color decoded")
check(env.R("Jail").priority == 1 and env.R("Jail").block_auto_assign, "priority and block auto assign decoded")
end)