mirror of
https://github.com/PHIDIAS0303/ExpCluster.git
synced 2026-11-18 23:03:13 +09:00
Let the framework own sets and lists instead of the features
Feature.to_set made every feature turn its config lists into sets on
each lookup, which is work the framework should do once. Sets are now a
field type of their own. Feature.set{...} declares one, the controller
sends a list, and _apply converts it when the override is applied, on
load and on update alike. Features index the config directly, and
to_set and its cache are gone.
Lists are explicit too. Feature.list{...} declares one, where before
any table of strings, and any empty table, counted as a list. Untagged
tables with string keys are nested sections, and other tables can not
be overridden. Feature.optional uses the same marker as list and set.
On the web side a string list can no longer name an input component,
so the cast that made one look like an object field is gone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
628e4df514
commit
f8ca285ff6
9 files changed
+128
-90
No files matched your search
@@ -78,15 +78,17 @@ function searchFields(feature: Feature, query: string) {
|
||||
function FieldInput(props: { field: FeatureField, value: FeatureValue, disabled: boolean, onChange: (value: FeatureValue) => void }) {
|
||||
const { field, value, disabled, onChange } = props;
|
||||
const control = useContext(ControlContext);
|
||||
const CustomInput = field.inputComponent ? control.inputComponents.get(field.inputComponent) : undefined;
|
||||
if (CustomInput) {
|
||||
const fieldDefinition = {
|
||||
type: field.type === "string_list" ? "object" : field.type,
|
||||
const CustomInput = field.type !== "string_list" && field.inputComponent
|
||||
? control.inputComponents.get(field.inputComponent)
|
||||
: undefined;
|
||||
if (CustomInput && field.type !== "string_list") {
|
||||
const fieldDefinition: lib.FieldDefinition = {
|
||||
type: field.type,
|
||||
title: field.title,
|
||||
description: field.description,
|
||||
optional: field.optional,
|
||||
inputComponent: field.inputComponent,
|
||||
} as lib.FieldDefinition;
|
||||
};
|
||||
return <CustomInput
|
||||
fieldDefinition={fieldDefinition}
|
||||
value={value as Exclude<FeatureValue, string[]>}
|
||||
|
||||
Reference in new issue
Block a user