Simplify checks based on review comments

Co-authored-by: Cooldude2606 <25043174+Cooldude2606@users.noreply.github.com>
This commit is contained in:
Danielv123andCooldude2606 committed 2025-01-25 17:39:47 +01:00
1 parent f78966860e
commit edfe32c59e
2 files changed
+3 -6

No files matched your search

+3 -5
View File
@@ -183,10 +183,8 @@ export class ItemDatabase {
if (typeof qualities === "number") { if (typeof qualities === "number") {
qualities = { normal: qualities }; qualities = { normal: qualities };
} }
for (const quality in qualities) { for (const count of Object.values(qualities)) {
if (Object.prototype.hasOwnProperty.call(qualities, quality)) { checkCount(count);
checkCount(qualities[quality]);
}
} }
this._items.set(name, qualities); this._items.set(name, qualities);
@@ -241,7 +239,7 @@ export class ItemDatabase {
getItemCount(name: string, quality: string): number { getItemCount(name: string, quality: string): number {
checkName(name); checkName(name);
if (!this._items.has(name) || !this._items.get(name)?.[quality]) { if (!this._items.get(name)?.[quality]) {
return 0; return 0;
} }
-1
View File
@@ -152,7 +152,6 @@ export class ControllerPlugin extends BaseControllerPlugin {
result.push(new Item(name, count, quality)); result.push(new Item(name, count, quality));
} }
} }
this.logger.verbose(`Sending storage update:\n${JSON.stringify(result)}`);
return result; return result;
} }