From edfe32c59e25f2f5947864523eaafff6acf98cac Mon Sep 17 00:00:00 2001 From: Danielv123 Date: Sat, 25 Jan 2025 17:38:40 +0100 Subject: [PATCH] Simplify checks based on review comments Co-authored-by: Cooldude2606 <25043174+Cooldude2606@users.noreply.github.com> --- packages/lib/src/database.ts | 8 +++----- plugins/subspace_storage/controller.ts | 1 - 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/packages/lib/src/database.ts b/packages/lib/src/database.ts index 4f2a0f90..915b3554 100644 --- a/packages/lib/src/database.ts +++ b/packages/lib/src/database.ts @@ -183,10 +183,8 @@ export class ItemDatabase { if (typeof qualities === "number") { qualities = { normal: qualities }; } - for (const quality in qualities) { - if (Object.prototype.hasOwnProperty.call(qualities, quality)) { - checkCount(qualities[quality]); - } + for (const count of Object.values(qualities)) { + checkCount(count); } this._items.set(name, qualities); @@ -241,7 +239,7 @@ export class ItemDatabase { getItemCount(name: string, quality: string): number { checkName(name); - if (!this._items.has(name) || !this._items.get(name)?.[quality]) { + if (!this._items.get(name)?.[quality]) { return 0; } diff --git a/plugins/subspace_storage/controller.ts b/plugins/subspace_storage/controller.ts index 7e84b5b9..958e7094 100644 --- a/plugins/subspace_storage/controller.ts +++ b/plugins/subspace_storage/controller.ts @@ -152,7 +152,6 @@ export class ControllerPlugin extends BaseControllerPlugin { result.push(new Item(name, count, quality)); } } - this.logger.verbose(`Sending storage update:\n${JSON.stringify(result)}`); return result; }