Setup logging transport in tests

Without a transport Winston will print annoying "Attempt to write logs
with no transports" warnings all over the place.  Setup a transport in
tests that cause logging to suppress this.

test/controller/Controller.js

@@ -12,6 +12,8 @@ import {
 	addPluginConfigFields,
 } from "@clusterio/lib";
 
+import "../setup_logging.js";
+
 class MockEvent {}
 
 class MockInstanceConfig extends EventEmitter {

test/controller/routes.js

@@ -7,6 +7,8 @@ import { wait, expositionContentType } from "@clusterio/lib";
 import * as routes from "@clusterio/controller/dist/node/src/routes.js";
 import * as mock from "../mock.js";
 
+import "../setup_logging.js";
+
 describe("controller/src/routes", function() {
 	let controller;
 	let server;

test/host.js

@@ -6,6 +6,7 @@ import * as lib from "@clusterio/lib";
 import Host, { _discoverInstances } from "@clusterio/host/dist/node/src/Host.js";
 import Instance from "@clusterio/host/dist/node/src/Instance.js";
 import { HostConnector } from "@clusterio/host/dist/node/host.js";
+import "./setup_logging.js";
 
 describe("Host testing", function() {
 	describe("discoverInstances()", function() {

test/host/Instance.js

@@ -6,6 +6,8 @@ import { PlayerStats, wait } from "@clusterio/lib";
 import Instance from "@clusterio/host/dist/node/src/Instance.js";
 import { MockConnector, MockLogger, MockServer } from "../mock.js";
 
+import "../setup_logging.js";
+
 const addr = lib.Address.fromShorthand;
 
 

test/host/server.js

@@ -7,6 +7,7 @@ import * as hostServer from "@clusterio/host/dist/node/src/server.js";
 import { Link, wait } from "@clusterio/lib";
 import { testLines } from "../lib/factorio/lines.js";
 import { slowTest, externalTest } from "../integration/index.js";
+import "../setup_logging.js";
 
 
 describe("host/server", function() {

test/integration/index.js

@@ -8,11 +8,13 @@ import util from "node:util";
 import events from "node:events";
 
 import * as lib from "@clusterio/lib";
-import { LineSplitter, ConsoleTransport, logger } from "@clusterio/lib";
+import { LineSplitter, logger } from "@clusterio/lib";
 
 import { selectTargetCommand, initialize as initializeCtl } from "@clusterio/ctl";
 import { _listFactorioVersions } from "@clusterio/host/dist/node/src/server.js";
 
+import "../setup_logging.js";
+
 // Make sure permissions from plugins are loaded
 import "../../plugins/global_chat/dist/node/index.js";
 import "../../plugins/player_auth/dist/node/index.js";
@@ -316,13 +318,6 @@ before(async function() {
 		console.log("SILENT_TEST is present in env, loggers after bootstrap will be muted.");
 	}
 
-	// Some integration tests may cause log events
-	logger.add(new ConsoleTransport({
-		level: "info",
-		format: new lib.TerminalFormat(),
-		filter: () => !silent,
-	}));
-
 	// If fast test is enabled then output that it is
 
 	if (process.env.FAST_TEST) {

test/lib/ModStore.test.js

@@ -9,6 +9,7 @@ const nativeFetch = global.fetch;
 
 import { ModStore, ModInfo, ModVersionEquality } from "@clusterio/lib"; // Adjust path based on compiled output
 import { externalTest } from "../integration/index.js";
+import "../setup_logging.js";
 
 const MODS_DIR = path.join("temp", "test", "mod_store", "mods");
 const CACHE_FILE = path.join(MODS_DIR, "mod-info-cache.json");

test/lib/bootstrap.test.js

@@ -4,6 +4,8 @@ import path from "node:path";
 
 import * as lib from "@clusterio/lib";
 
+import "../setup_logging.js";
+
 describe("lib/bootstrap", function() {
 	describe("loadConfigFromArgs()", function() {
 		const folder = path.join("temp", "test", "bootstrap");

test/lib/datastore.js

@@ -3,6 +3,7 @@ import assert from "node:assert/strict";
 import * as lib from "@clusterio/lib";
 import fs from "node:fs/promises";
 import path from "node:path";
+import "../setup_logging.js";
 
 class MockDatastoreProvider extends lib.DatastoreProvider {
 	constructor() {

test/lib/link/connector.js

@@ -1,8 +1,9 @@
 import assert from "node:assert/strict";
 import events from "node:events";
 
-import * as mock from "../../mock.js";
 import * as lib from "@clusterio/lib";
+import * as mock from "../../mock.js";
+import "../../setup_logging.js";
 
 
 describe("lib/link/connectors", function() {

test/lib/link/link.js

@@ -3,6 +3,7 @@ import events from "node:events";
 
 import * as lib from "@clusterio/lib";
 import * as mock from "../../mock.js";
+import "../../setup_logging.js";
 
 const addr = lib.Address.fromShorthand;
 

test/lib/logging_utils.js

@@ -4,6 +4,7 @@ import path from "node:path";
 
 import { testLines } from "./factorio/lines.js";
 import * as lib from "@clusterio/lib";
+import "../setup_logging.js";
 
 
 describe("lib/logging_utils.js", function() {

test/lib/rce_ops.js

@@ -1,5 +1,6 @@
 import assert from "node:assert/strict";
 import * as lib from "@clusterio/lib";
+import "../setup_logging.js";
 
 describe("rce_ops", function() {
 	describe("updatePackage", function() {

test/lib/shared_commands.js

@@ -4,6 +4,7 @@ import path from "node:path";
 
 import * as lib from "@clusterio/lib";
 import { slowTest } from "../integration/index.js";
+import "../setup_logging.js";
 
 
 describe("lib/shared_commands", function() {

test/lib/subscriptions.test.js

@@ -3,6 +3,7 @@ import assert from "node:assert/strict";
 import * as lib from "@clusterio/lib";
 import { MockController, MockConnector, MockControl } from "../mock.js";
 import { testMatrix, testRoundTripJsonSerialisable } from "../common.js";
+import "../setup_logging.js";
 
 const addr = lib.Address.fromShorthand;
 

test/messages/controller.test.js

@@ -6,6 +6,7 @@ import * as lib from "@clusterio/lib";
 
 import { Controller, ControlConnection } from "@clusterio/controller";
 import { testMatrix, testRoundTripJsonSerialisable } from "../common.js";
+import "../setup_logging.js";
 
 describe("messages/controller", function() {
 	/** @type {Controller} */

test/messages/host.test.js

@@ -3,6 +3,7 @@ import * as lib from "@clusterio/lib";
 
 import { Host } from "@clusterio/host";
 import { testMatrix, testRoundTripJsonSerialisable } from "../common.js";
+import "../setup_logging.js";
 
 describe("messages/host", function() {
 	/** @type {Host} */

test/messages/mod.test.js

@@ -7,6 +7,7 @@ import { testMatrix, testRoundTripJsonSerialisable } from "../common.js";
 
 import { Controller, ControlConnection } from "@clusterio/controller";
 import { externalTest } from "../integration/index.js";
+import "../setup_logging.js";
 
 describe("messages/mod", function() {
 	/** @type {Controller} */

test/messages/plugin.test.js

@@ -4,6 +4,8 @@ import * as lib from "@clusterio/lib";
 import { Controller, ControlConnection } from "@clusterio/controller";
 import { Host } from "@clusterio/host";
 
+import "../setup_logging.js";
+
 describe("messages/plugin", function() {
 	/** @type {Host} */
 	let host;

test/setup_logging.js

@@ -0,0 +1,15 @@
+import { ConsoleTransport, TerminalFormat, logger } from "@clusterio/lib";
+
+// Some integration tests may cause log events, import this file for such tests
+// to avoid getting the "Attempt to write logs with no transports" warning when
+// running tests individually.
+
+before(function() {
+	const silent = process.env.SILENT_TEST;
+
+	logger.add(new ConsoleTransport({
+		level: "info",
+		format: new TerminalFormat(),
+		filter: () => !silent,
+	}));
+});