aperx/factorio-clusterio
1
0 Fork 0
mirror of https://github.com/clusterio/clusterio.git synced 2026-11-14 15:24:52 +09:00
Code Issues Packages Projects Releases Wiki Activity

/api/rconPasswords fix & /api/slaves security fix (#179)

Browse Source 
Fix for /api/slaves to not send rconPasswords
Fix for /api/rconPasswords to work properly and send partial information
This commit is contained in:
Master-Guy authored and Daniel committed 2019-07-20 15:52:47 +02:00
1 parent d909b4aa47
commit e2775adcc3
1 file changed
+7 -5
Download Patch File Download Diff File Expand all files Collapse all files
master.js
+7 -5
View File
@@ -465,8 +465,8 @@ app.get("/api/slaves", function(req, res) {
res.header("Access-Control-Allow-Origin", "*");
res.header("Access-Control-Allow-Headers", "Origin, X-Requested-With, Content-Type, Accept");
let slaveCache = getSlaves();
for(key in slaveCache) {
slaveCache[key].rconPassword = "hidden";
for(key in slaveCache.cache) {
slaveCache.cache[key].rconPassword = "hidden";
}
res.send(slaveCache.cache);
});
@@ -481,9 +481,11 @@ app.post("/api/rconPasswords", authenticate.middleware, function(req, res) {
res.header("Access-Control-Allow-Origin", "*");
res.header("Access-Control-Allow-Headers", "Origin, X-Requested-With, Content-Type, Accept");
let slaveCache = getSlaves();
let serverInfo = [];
serverInfo[key] = {id: key, rconPassword: slaveCache[key].rconPassword};
res.send(serverInfo);
let validKeys = ['rconPort', 'rconPassword', 'publicIP'];
for(key in slaveCache.cache) {
slaveCache.cache[key] = {'publicIP': slaveCache.cache[key].publicIP, 'rconPort': slaveCache.cache[key].rconPort, 'rconPassword': slaveCache.cache[key].rconPassword};
}
res.send(slaveCache.cache);
});
/*
var recievedItemStatistics = new averagedTimeSeries({