Define fake DOM globals as non-enumerable in tests

mocha --check-leaks flagged window, document and ResizeObserver set by
the scroll restoration tests. Define them with defineProperty and restore
the original descriptors afterwards.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
bbassieandClaude Opus 5.5 committed 2026-11-21 02:54:18 +00:00
1 parent 628e59bf2c
commit e1ffb848b1
1 file changed
+21 -8
+21 -8
View File
@@ -56,19 +56,32 @@ function resize(maxScroll) {
} }
} }
// Non-enumerable so mocha --check-leaks ignores them
function withDom() { function withDom() {
const names = ["window", "document", "sessionStorage", "ResizeObserver"];
const saved = new Map();
beforeEach(function() { beforeEach(function() {
FakeResizeObserver.observers.clear(); FakeResizeObserver.observers.clear();
globalThis.window = new FakeWindow(); const fakes = {
globalThis.document = { body: {} }; window: new FakeWindow(),
globalThis.sessionStorage = new MemoryStorage(); document: { body: {} },
globalThis.ResizeObserver = FakeResizeObserver; sessionStorage: new MemoryStorage(),
ResizeObserver: FakeResizeObserver,
};
for (const name of names) {
saved.set(name, Object.getOwnPropertyDescriptor(globalThis, name));
Object.defineProperty(globalThis, name, { value: fakes[name], configurable: true, writable: true });
}
}); });
afterEach(function() { afterEach(function() {
delete globalThis.window; for (const name of names) {
delete globalThis.document; const descriptor = saved.get(name);
delete globalThis.sessionStorage; if (descriptor) {
delete globalThis.ResizeObserver; Object.defineProperty(globalThis, name, descriptor);
} else {
delete globalThis[name];
}
}
}); });
} }