From e1ffb848b19b975456cbde505fd64d1ed27d2df3 Mon Sep 17 00:00:00 2001 From: bbassie <17990055+bbassie@users.noreply.github.com> Date: Sat, 21 Nov 2026 02:54:18 +0000 Subject: [PATCH] Define fake DOM globals as non-enumerable in tests mocha --check-leaks flagged window, document and ResizeObserver set by the scroll restoration tests. Define them with defineProperty and restore the original descriptors afterwards. Co-Authored-By: Claude Opus 5.5 --- test/web_ui/useScrollRestoration.js | 29 +++++++++++++++++++++-------- 1 file changed, 21 insertions(+), 8 deletions(-) diff --git a/test/web_ui/useScrollRestoration.js b/test/web_ui/useScrollRestoration.js index 989b4fce..dec3ad03 100644 --- a/test/web_ui/useScrollRestoration.js +++ b/test/web_ui/useScrollRestoration.js @@ -56,19 +56,32 @@ function resize(maxScroll) { } } +// Non-enumerable so mocha --check-leaks ignores them function withDom() { + const names = ["window", "document", "sessionStorage", "ResizeObserver"]; + const saved = new Map(); beforeEach(function() { FakeResizeObserver.observers.clear(); - globalThis.window = new FakeWindow(); - globalThis.document = { body: {} }; - globalThis.sessionStorage = new MemoryStorage(); - globalThis.ResizeObserver = FakeResizeObserver; + const fakes = { + window: new FakeWindow(), + document: { body: {} }, + sessionStorage: new MemoryStorage(), + ResizeObserver: FakeResizeObserver, + }; + for (const name of names) { + saved.set(name, Object.getOwnPropertyDescriptor(globalThis, name)); + Object.defineProperty(globalThis, name, { value: fakes[name], configurable: true, writable: true }); + } }); afterEach(function() { - delete globalThis.window; - delete globalThis.document; - delete globalThis.sessionStorage; - delete globalThis.ResizeObserver; + for (const name of names) { + const descriptor = saved.get(name); + if (descriptor) { + Object.defineProperty(globalThis, name, descriptor); + } else { + delete globalThis[name]; + } + } }); }