Add feature flags to first party plugins

plugins/global_chat/index.ts

@@ -9,6 +9,10 @@ export const plugin: lib.PluginDeclaration = {
 	instanceEntrypoint: "dist/node/instance",
 	ctlEntrypoint: "dist/node/control",
 
+	features: [
+		"ScriptCommands",
+	],
+
 	messages: [
 		ChatEvent,
 	],

plugins/global_chat/instance.ts

@@ -16,10 +16,6 @@ export class InstancePlugin extends BaseInstancePlugin {
 	messageQueue: string[] = [];
 
 	async init() {
-		if (!this.instance.config.get("factorio.enable_script_commands")) {
-			throw new Error("global_chat plugin requires script commands.");
-		}
-
 		this.instance.handle(ChatEvent, this.handleChatEvent.bind(this));
 	}
 

plugins/inventory_sync/index.ts

@@ -45,6 +45,11 @@ export const plugin: lib.PluginDeclaration = {
 		},
 	},
 
+	features: [
+		"SavePatching",
+		"ScriptCommands",
+	],
+
 	messages: [
 		messages.AcquireRequest,
 		messages.ReleaseRequest,

plugins/inventory_sync/instance.ts

@@ -31,12 +31,6 @@ export class InstancePlugin extends BaseInstancePlugin {
 	disconnecting!: boolean;
 
 	async init() {
-		if (!this.instance.config.get("factorio.enable_save_patching")) {
-			throw new Error("inventory_sync plugin requires save patching.");
-		}
-		if (!this.instance.config.get("factorio.enable_script_commands")) {
-			throw new Error("inventory_sync plugin requires script commands.");
-		}
 		this.playersToRelease = new Set();
 		this.disconnecting = false;
 

plugins/player_auth/index.ts

@@ -33,6 +33,10 @@ export const plugin: lib.PluginDeclaration = {
 		},
 	},
 
+	features: [
+		"SavePatching",
+	],
+
 	messages: [
 		messages.FetchPlayerCodeRequest,
 		messages.SetVerifyCodeRequest,

plugins/player_auth/instance.ts

@@ -13,10 +13,6 @@ type IpcPlayerAuth = {
 
 export class InstancePlugin extends BaseInstancePlugin {
 	async init() {
-		if (!this.instance.config.get("factorio.enable_save_patching")) {
-			throw new Error("player_auth plugin requires save patching.");
-		}
-
 		this.instance.server.on(
 			"ipc-player_auth",
 			(ipcPlayerAuth: IpcPlayerAuth) => this.handleEvent(ipcPlayerAuth).catch(

plugins/research_sync/index.ts

@@ -9,6 +9,11 @@ export const plugin: lib.PluginDeclaration = {
 	instanceEntrypoint: "dist/node/instance",
 	controllerEntrypoint: "dist/node/controller",
 
+	features: [
+		"SavePatching",
+		"ScriptCommands",
+	],
+
 	messages: [
 		messages.ContributionEvent,
 		messages.ProgressEvent,

plugins/research_sync/instance.ts

@@ -27,13 +27,6 @@ export class InstancePlugin extends BaseInstancePlugin {
 	}
 
 	async init() {
-		if (!this.instance.config.get("factorio.enable_save_patching")) {
-			throw new Error("research_sync plugin requires save patching.");
-		}
-		if (!this.instance.config.get("factorio.enable_script_commands")) {
-			throw new Error("research_sync plugin requires script commands.");
-		}
-
 		this.instance.server.on("ipc-research_sync:contribution", (tech: IpcContribution) => {
 			this.researchContribution(tech).catch(err => this.unexpectedError(err));
 		});

plugins/statistics_exporter/index.ts

@@ -22,4 +22,9 @@ export const plugin: lib.PluginDeclaration = {
 			initialValue: 1,
 		},
 	},
+
+	features: [
+		"SavePatching",
+		"ScriptCommands",
+	],
 };

plugins/statistics_exporter/instance.ts

@@ -104,15 +104,6 @@ function setForceFlowStatistic(
 
 
 export class InstancePlugin extends BaseInstancePlugin {
-	async init() {
-		if (!this.instance.config.get("factorio.enable_save_patching")) {
-			throw new Error("statistics_exporter plugin requires save patching.");
-		}
-		if (!this.instance.config.get("factorio.enable_script_commands")) {
-			throw new Error("statistics_exporter plugin requires script commands.");
-		}
-	}
-
 	async gatherMetrics() {
 		let string = await this.sendRcon("/sc statistics_exporter.export()");
 		let stats: IpcStats;

plugins/subspace_storage/index.ts

@@ -49,6 +49,10 @@ export const plugin: lib.PluginDeclaration = {
 		},
 	},
 
+	features: [
+		"ScriptCommands",
+	],
+
 	messages: [
 		messages.PlaceEvent,
 		messages.RemoveRequest,

plugins/subspace_storage/instance.ts

@@ -22,10 +22,6 @@ export class InstancePlugin extends BaseInstancePlugin {
 	}
 
 	async init() {
-		if (!this.instance.config.get("factorio.enable_script_commands")) {
-			throw new Error("subspace_storage plugin requires script commands.");
-		}
-
 		this.pendingTasks = new Set();
 		this.instance.server.on("ipc-subspace_storage:output", (output: IpcItems) => {
 			this.logger.info("Received output items:");