Use strict mode

Add strict mode directives to all js files.

clusterctl.js

@@ -2,6 +2,7 @@
  * Command line interface for controlling a Clusterio cluster
  * @module
  */
+"use strict";
 const jwt = require("jsonwebtoken");
 const fs = require("fs-extra");
 const yargs = require("yargs");
@@ -730,7 +731,7 @@ async function startControl() {
 	});
 
 	if (commands.has(commandName)) {
-		command = commands.get(commandName);
+		let command = commands.get(commandName);
 
 		try {
 			await command.run(args, control);

lib/config/index.js

@@ -3,6 +3,7 @@
  * @author Hornwitser
  * @module lib/config
  */
+"use strict";
 module.exports = {
 	...require("./classes"),
 	...require("./definitions"),

lib/errors.js

@@ -2,6 +2,7 @@
  * Errors thrown in Clusterio
  * @module
  */
+"use strict";
 
 /**
  * Thrown by commands when they fail

lib/factorio/index.js

@@ -3,6 +3,7 @@
  * @module lib/factorio
  * @author Hornwitser
  */
+"use strict";
 module.exports = {
 	...require("lib/factorio/export"),
 	...require("lib/factorio/patch"),

lib/fileOps/fileOps.js

@@ -1,6 +1,7 @@
 /**
  * @module lib/fileOps
  */
+"use strict";
 const fs = require("fs-extra");
 const path = require("path");
 

lib/fileOps/index.js

@@ -1,2 +1,3 @@
+"use strict";
 const fileOps = require("./fileOps");
 module.exports = fileOps;

lib/generateSSLcert.js

@@ -1,3 +1,4 @@
+"use strict";
 const forge = require("node-forge");
 const fs = require("fs-extra");
 const util = require("util");

lib/hash.js

@@ -2,6 +2,7 @@
  * Hashing functions
  * @module
  */
+"use strict";
 const crypto = require("crypto");
 const fs = require("fs");
 

lib/helpers.js

@@ -2,6 +2,7 @@
  * Collection of small utilites that are useful in multiple places.
  * @module
  */
+"use strict";
 
 /**
  * Return a string describing the type of the value passed

lib/link/index.js

@@ -3,6 +3,7 @@
  * @module lib/link
  * @author Hornwitser
  */
+"use strict";
 module.exports = {
 	...require("lib/link/link"),
 	...require("lib/link/messages"),

lib/luaTools.js

@@ -2,6 +2,7 @@
  * Utilities for dealing with Lua
  * @module
  */
+"use strict";
 
 /**
  * Escapes a string for inclusion into a lua string

lib/manager/modManager.js

@@ -3,6 +3,7 @@ Provides tools to manage mods in a clusterio install
 @module
 */
 
+"use strict";
 const asTable = require("as-table").configure({delimiter: " | "});
 const moment = require("moment");
 const syncRequest = require("sync-request");

lib/npmPostinstall.js

@@ -1,3 +1,4 @@
+"use strict";
 var http = require("http");
 var https = require("https");
 var fs = require("fs-extra");

lib/objectOps.js

@@ -2,6 +2,7 @@
 Helper functions related to objects
 @module
 */
+"use strict";
 
 /**
 Deep clones an object, is actually just JSON.parse(JSON.stringify()) but looks cleaner.

lib/prometheus.js

@@ -1,3 +1,4 @@
+"use strict";
 class Metric {
 	constructor(type, name, help, labels = []) {
 		if (typeof name !== "string") {

lib/schema.js

@@ -2,6 +2,7 @@
  * JSON schemas used for validating link messages
  * @module
  */
+"use strict";
 const ajv = new (require("ajv"))({
 	verbose: true,
 	format: "full",

master.js

@@ -16,6 +16,7 @@
 // const updater = require("./updater");
 // updater.update().then(console.log);
 
+"use strict";
 const deepmerge = require("deepmerge");
 const path = require("path");
 const fs = require("fs-extra");
@@ -318,7 +319,7 @@ function createUser(name) {
 	}
 
 	let defaultRoleId = masterConfig.get("master.default_role_id");
-	user = new users.User({ name, roles: [defaultRoleId] }, db.roles);
+	let user = new users.User({ name, roles: [defaultRoleId] }, db.roles);
 	db.users.set(name, user);
 	return user;
 }
@@ -1365,7 +1366,7 @@ async function pluginManagement(pluginInfos) {
 
 async function loadPlugins(pluginInfos) {
 	let plugins = new Map();
-	for (pluginInfo of pluginInfos) {
+	for (let pluginInfo of pluginInfos) {
 		if (!masterConfig.group(pluginInfo.name).get("enabled")) {
 			continue;
 		}

plugins/global_chat/info.js

@@ -1,3 +1,4 @@
+"use strict";
 let link = require("lib/link");
 let plugin = require("lib/plugin");
 

plugins/global_chat/instance.js

@@ -1,6 +1,7 @@
 /**
  * @module
  */
+"use strict";
 const plugin = require("lib/plugin");
 const luaTools = require("lib/luaTools");
 

plugins/global_chat/test/plugin.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 
 const mock = require("../../../test/mock");

plugins/research_sync/info.js

@@ -1,3 +1,4 @@
+"use strict";
 const link = require("lib/link");
 
 

plugins/research_sync/instance.js

@@ -1,3 +1,4 @@
+"use strict";
 const needle = require("needle");
 
 const plugin = require("lib/plugin");

plugins/research_sync/master.js

@@ -1,3 +1,4 @@
+"use strict";
 const fs = require("fs-extra");
 const path = require("path");
 

plugins/research_sync/test/missing.js

@@ -1,5 +1,6 @@
 // These are libraries that does not have any units test, they are
 // required here in order to track coverage for them.
 
+"use strict";
 require("../instance");
 require("../master");

plugins/statistics_exporter/info.js

@@ -1,3 +1,4 @@
+"use strict";
 let link = require("lib/link");
 
 module.exports = {

plugins/statistics_exporter/instance.js

@@ -1,3 +1,4 @@
+"use strict";
 const plugin = require("lib/plugin");
 const { Gauge } = require("lib/prometheus");
 

plugins/statistics_exporter/test/plugin.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 
 const mock = require("../../../test/mock");

plugins/subspace_storage/dole.js

@@ -1,3 +1,4 @@
+"use strict";
 const doleNN = require("./dole_nn_base");
 
 const prometheus = require("lib/prometheus");

plugins/subspace_storage/dole_nn_base.js

@@ -1,5 +1,6 @@
 //Sigmoids...
 
+"use strict";
 function sigmoid0(x)
 {
 	return x/(1+Math.abs(x));

plugins/subspace_storage/info.js

@@ -1,3 +1,4 @@
+"use strict";
 const link = require("lib/link");
 const config = require("lib/config");
 

plugins/subspace_storage/instance.js

@@ -1,3 +1,4 @@
+"use strict";
 const fs = require("fs-extra");
 
 const plugin = require("lib/plugin");

plugins/subspace_storage/routes.js

@@ -1,3 +1,4 @@
+"use strict";
 const express = require("express");
 const path = require("path");
 

plugins/subspace_storage/static/storage.js

@@ -1,4 +1,5 @@
 // function to draw data we recieve from ajax requests
+"use strict";
 _lastData = [];
 function drawcontents(data) {
 	data = data || _lastData; //Cache data so we can drawcontents without waiting for the server, for the search box.

plugins/subspace_storage/test/missing.js

@@ -1,6 +1,7 @@
 // These are libraries that does not have any units test, they are
 // required here in order to track coverage for them.
 
+"use strict";
 require("../instance");
 require("../master");
 require("../dole");

plugins/subspace_storage/test/routes.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 
 const routes = require("../routes");

routes.js

@@ -1,3 +1,4 @@
+"use strict";
 module.exports = function(app) {
 	app.get("/", function(req, res) {
 		res.render("index");

slave.js

@@ -10,6 +10,7 @@
  * @example
  * node slave run
  */
+"use strict";
 const fs = require("fs-extra");
 const path = require("path");
 const yargs = require("yargs");

test/clusterctl.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 const chalk = require("chalk");
 

test/integration/clusterio.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 const fs = require("fs-extra");
 const path = require("path");

test/integration/export.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 const path = require("path");
 

test/integration/index.js

@@ -1,3 +1,4 @@
+"use strict";
 const path = require("path");
 const fs = require("fs-extra");
 const child_process = require("child_process");

test/integration/link.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 const events = require("events");
 const jwt = require("jsonwebtoken");

test/integration/patch.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 const fs = require("fs-extra");
 const jszip = require("jszip");

test/integration/server.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 const events = require("events");
 const fs = require("fs-extra");

test/lib/database.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 const fs = require("fs-extra");
 const path = require("path");

test/lib/factorio/export.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 const path = require("path");
 

test/lib/factorio/lines.js

@@ -1,5 +1,6 @@
 // Lines for testing the factorio output
 
+"use strict";
 let testLines = new Map([
 	[
 		"   1.306 Info RemoteCommandProcessor.cpp:131: Starting RCON interface at port 4000",

test/lib/factorio/patch.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 const fs = require("fs-extra");
 const jszip = require("jszip");

test/lib/factorio/server.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 const events = require("events");
 const fs = require("fs-extra");

test/lib/fileOps/fileOps.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 const fs = require("fs-extra");
 const path = require("path");

test/lib/generateSSLcert.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert");
 const fs = require("fs-extra");
 const path = require("path");

test/lib/hash.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 const fs = require("fs");
 const path = require("path");

test/lib/helpers.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 
 const helpers = require("lib/helpers");

test/lib/link/connector.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 const events = require("events");
 

test/lib/link/link.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 const events = require("events");
 

test/lib/link/messages.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 
 const link = require("lib/link");

test/lib/luaTools.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 
 const luaTools = require("lib/luaTools");

test/lib/objectOps.js

@@ -1,3 +1,4 @@
+"use strict";
 var assert = require("assert");
 var objectOps = require("lib/objectOps");
 

test/lib/plugin.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 const fs = require("fs-extra");
 const path = require("path");

test/lib/prometheus.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 
 const prometheus = require("lib/prometheus");

test/lib/users.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 const users = require("lib/users");
 

test/master.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 
 const mock = require("./mock");

test/missing.js

@@ -1,5 +1,6 @@
 // These are libraries that does not have any units test, they are
 // required here in order to track coverage for them.
 
+"use strict";
 require("lib/manager/modManager");
 require("lib/npmPostinstall.js");

test/mock.js

@@ -1,3 +1,4 @@
+"use strict";
 const events = require("events");
 
 const link = require("lib/link");

test/slave.js

@@ -1,3 +1,4 @@
+"use strict";
 const assert = require("assert").strict;
 const path = require("path");
 const fs = require("fs-extra");