From 290ec4f26b362a7d58175dbcf321f3bb9b891660 Mon Sep 17 00:00:00 2001 From: Cooldude2606 Date: Sun, 24 Jan 2021 02:39:20 +0000 Subject: [PATCH 1/3] Bumped lua action to v8 --- .github/workflows/dev-deploy.yml | 2 +- .github/workflows/pr-checker.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/dev-deploy.yml b/.github/workflows/dev-deploy.yml index 418d1360..f1d49189 100644 --- a/.github/workflows/dev-deploy.yml +++ b/.github/workflows/dev-deploy.yml @@ -18,7 +18,7 @@ jobs: fetch-depth: 0 - name: Install Lua - uses: leafo/gh-actions-lua@v5 + uses: leafo/gh-actions-lua@v8.0.0 - name: Install LuaRocks uses: leafo/gh-actions-luarocks@v2 diff --git a/.github/workflows/pr-checker.yml b/.github/workflows/pr-checker.yml index 77e50408..f2277cd5 100644 --- a/.github/workflows/pr-checker.yml +++ b/.github/workflows/pr-checker.yml @@ -28,7 +28,7 @@ jobs: fetch-depth: 0 - name: Install Lua - uses: leafo/gh-actions-lua@v5 + uses: leafo/gh-actions-lua@v8.0.0 - name: Install LuaRocks uses: leafo/gh-actions-luarocks@v2 From a7b1d33777b4e603bb512f4e908b7fd7438541a5 Mon Sep 17 00:00:00 2001 From: Cooldude2606 Date: Sun, 24 Jan 2021 02:56:49 +0000 Subject: [PATCH 2/3] Bumped luarocks action to v4 --- .github/workflows/dev-deploy.yml | 2 +- .github/workflows/pr-checker.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/dev-deploy.yml b/.github/workflows/dev-deploy.yml index f1d49189..d1773da3 100644 --- a/.github/workflows/dev-deploy.yml +++ b/.github/workflows/dev-deploy.yml @@ -21,7 +21,7 @@ jobs: uses: leafo/gh-actions-lua@v8.0.0 - name: Install LuaRocks - uses: leafo/gh-actions-luarocks@v2 + uses: leafo/gh-actions-luarocks@v4 - name: Install LDoc run: luarocks install ldoc 1.4.4-1 diff --git a/.github/workflows/pr-checker.yml b/.github/workflows/pr-checker.yml index f2277cd5..aaf4242a 100644 --- a/.github/workflows/pr-checker.yml +++ b/.github/workflows/pr-checker.yml @@ -31,7 +31,7 @@ jobs: uses: leafo/gh-actions-lua@v8.0.0 - name: Install LuaRocks - uses: leafo/gh-actions-luarocks@v2 + uses: leafo/gh-actions-luarocks@v4 - name: Install LDoc run: luarocks install ldoc 1.4.4-1 From ca8d03304c968d40457190db3d1fe96da960af29 Mon Sep 17 00:00:00 2001 From: Bastiaan Date: Sun, 24 Jan 2021 19:41:23 +0100 Subject: [PATCH 3/3] Removed one use variable Co-authored-by: Cooldude2606 --- modules/gui/warp-list.lua | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/modules/gui/warp-list.lua b/modules/gui/warp-list.lua index f3f08e7b..e4f08fc5 100644 --- a/modules/gui/warp-list.lua +++ b/modules/gui/warp-list.lua @@ -94,8 +94,7 @@ Gui.element{ local water_tiles = surface.find_tiles_filtered{ collision_mask = "water-tile", radius = config.standard_proximity_radius + 1, position = position } if #water_tiles > 0 then player_return({'expcore-commands.command-fail', {'warp-list.too-close-to-water', config.standard_proximity_radius + 1}}, 'orange_red', player) - local play_sound = 'utility/wire_pickup' - if game.player then game.player.play_sound{path=play_sound} end + if game.player then game.player.play_sound{ path = 'utility/wire_pickup' } end for _, tile in pairs(water_tiles) do rendering.draw_sprite{ sprite = 'utility/rail_path_not_possible', @@ -862,4 +861,4 @@ local function maintain_tag(event) end Event.add(defines.events.on_chart_tag_modified, maintain_tag) -Event.add(defines.events.on_chart_tag_removed, maintain_tag) \ No newline at end of file +Event.add(defines.events.on_chart_tag_removed, maintain_tag)