aperx/factorio-scenario-ExpCluster
1
0
Fork 0
mirror of https://github.com/PHIDIAS0303/ExpCluster.git synced 2025-12-30 20:41:41 +09:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: mark9064 <30447455+mark9064@users.noreply.github.com>
This commit is contained in:
Bastiaan
2021-04-27 23:33:05 +02:00
committed by GitHub
parent 254d69f646
commit ea8e093c31
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
modules/gui/task-list.lua
View File

@@ -320,12 +320,12 @@ local message_pattern = "(.-)\n(.*)"
--- Parse a string into a message object with title and body --- Parse a string into a message object with title and body
-- @tparam string str message data -- @tparam string str message data
local function parse_message(str) local function parse_message(str)
-- Trimm the spaces of the string -- Trim the spaces of the string
local trimmed = string.gsub(str, "^%s*(.-)%s*$", "%1") local trimmed = string.gsub(str, "^%s*(.-)%s*$", "%1")
local message = { title = "", body = "" } local message = { title = "", body = "" }
local title, body = string.match(trimmed, message_pattern) local title, body = string.match(trimmed, message_pattern)
if not title then if not title then
-- If it doesn't match the patter return the str as a title -- If it doesn't match the pattern return the str as a title
message.title = trimmed message.title = trimmed
else else
message.title = title message.title = title
@@ -501,7 +501,7 @@ local task_list_container =
task_view_footer_element.visible = false task_view_footer_element.visible = false
task_edit_footer_element.visible = false task_edit_footer_element.visible = false
task_create_footer_element.visible = false task_create_footer_element.visible = false
-- Return the exteral container -- Return the external container
return container.parent return container.parent
end end
):add_to_left_flow( ):add_to_left_flow(
@@ -675,7 +675,7 @@ PlayerSelected:on_update(
edit_flow.visible = false edit_flow.visible = false
end end
else else
-- If new state nil then hide footer elements and set editing to nil for old_state -- If new state is nil then hide footer elements and set editing to nil for old_state
if old_state then if old_state then
Tasks.set_editing(old_state, player.name, nil) Tasks.set_editing(old_state, player.name, nil)
end end
@@ -718,7 +718,7 @@ local function role_update_event(event)
PlayerSelected:set(selected) PlayerSelected:set(selected)
end end
-- Update the new task button and create footer incase the user can now add them -- Update the new task button and create footer in case the user can now add them
local has_permission = check_player_permissions(player) local has_permission = check_player_permissions(player)
local add_new_task_element = container.header.alignment[add_new_task.name] local add_new_task_element = container.header.alignment[add_new_task.name]
add_new_task_element.visible = has_permission add_new_task_element.visible = has_permission