Defer need-check-nil and clean up stale suppressions

emmylua deserialises an unknown diagnostic code to a catch all that
matches no checker, so every `invisible`, `nil-check` and
`global-element` suppression was silently doing nothing. Renamed to the
emmylua codes. `name-style-check` has no equivalent and is dropped, it
was already disabled under luals.

The `get_tile` suppressions referenced an api typedef bug from 2024
which no longer reproduces.

need-check-nil is deferred rather than disabled on merit: a third of the
407 findings come from MapPosition and BoundingBox being aliased as
`struct|[double, double]`, so every `entity.position.x` reads as
possibly nil. The rest need per site knowledge of runtime invariants.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

exp_scenario/module/commands/roles.lua

@@ -55,7 +55,7 @@ Commands.new("get-roles", { "exp-commands_roles.description-get" })
         end
 
         local last = #roles_formatted
-        --- @diagnostic disable-next-line nil-check
+        --- @diagnostic disable-next-line: need-check-nil
         roles_formatted[last] = roles_formatted[last][2]
 
         return Commands.status.success(response)

exp_scenario/module/control/degrading_tiles.lua

@@ -18,7 +18,6 @@ end
 --- @param surface LuaSurface
 --- @param position MapPosition
 local function degrade_tile(surface, position)
-    --- @diagnostic disable-next-line Incorrect Api Type: https://forums.factorio.com/viewtopic.php?f=233&t=109145&p=593761&hilit=get_tile#p593761
     local tile = surface.get_tile(position)
     local tile_name = tile.name
     local degrade_tile_name = config.degrade_order[tile_name]
@@ -61,7 +60,6 @@ end
 --- @param position MapPosition
 --- @return number?
 local function get_tile_strength(surface, position)
-    --- @diagnostic disable-next-line Incorrect Api Type: https://forums.factorio.com/viewtopic.php?f=233&t=109145&p=593761&hilit=get_tile#p593761
     local tile = surface.get_tile(position)
     local tile_name = tile.name
     local strength = config.strengths[tile_name]

exp_scenario/module/control/spawn_area.lua

@@ -164,7 +164,6 @@ local function clear_spawn_area(surface, offset)
     local get_tile = surface.get_tile
 
     -- Make sure a non water tile is used for filling
-    --- @diagnostic disable-next-line Incorrect Api Type: https://forums.factorio.com/viewtopic.php?f=233&t=109145&p=593761&hilit=get_tile#p593761
     local starting_tile = get_tile(offset)
     local fill_tile = starting_tile.collides_with("player") and "landfill" or starting_tile.name
     local fill_radius = config.spawn_area.landfill_radius
@@ -185,7 +184,6 @@ local function clear_spawn_area(surface, offset)
             if dst < tile_radius_sqr then
                 -- If it is inside the decon radius always set the tile
                 tiles_to_make[#tiles_to_make + 1] = { name = decon_tile, position = pos }
-                --- @diagnostic disable-next-line Incorrect Api Type: https://forums.factorio.com/viewtopic.php?f=233&t=109145&p=593761&hilit=get_tile#p593761
             elseif dst < fill_radius_sqr and get_tile(pos).collides_with("player") then
                 -- If it is inside the fill radius only set the tile if it is water
                 tiles_to_make[#tiles_to_make + 1] = { name = fill_tile, position = pos }

exp_scenario/module/gui/debug/expcore_gui_view.lua

@@ -27,7 +27,7 @@ function Public.show(container)
     local left_panel_style = left_panel.style
     left_panel_style.width = 300
 
-    --- @diagnostic disable-next-line invisible
+    --- @diagnostic disable-next-line: access-invisible
     for element_name in pairs(ExpElement._elements) do
         local header = left_panel.add{ type = "flow" }.add{ type = "label", name = header_name, caption = element_name }
         Gui.set_data(header, element_name)
@@ -92,18 +92,18 @@ Gui.on_click(
         input_text_box.text = concat{ "ExpElement._elements[\"", element_name, "\"]" }
         input_text_box.style.font_color = Color.black
 
-        --- @diagnostic disable-next-line invisible
+        --- @diagnostic disable-next-line: access-invisible
         local define = ExpElement._elements[element_name]
         local content = dump({
-            --- @diagnostic disable-next-line invisible
+            --- @diagnostic disable-next-line: access-invisible
             debug = define._debug,
-            --- @diagnostic disable-next-line invisible
+            --- @diagnostic disable-next-line: access-invisible
             has_handlers = define._has_handlers,
-            --- @diagnostic disable-next-line invisible
+            --- @diagnostic disable-next-line: access-invisible
             track_elements = define._track_elements,
-            --- @diagnostic disable-next-line invisible
+            --- @diagnostic disable-next-line: access-invisible
             elements = ExpIter._scopes[element_name],
-            --- @diagnostic disable-next-line invisible
+            --- @diagnostic disable-next-line: access-invisible
             data = ExpData._scopes[element_name]._raw,
         }) or "nil"
         right_panel.text = content

exp_scenario/module/gui/debug/redmew_global_view.lua

@@ -24,7 +24,7 @@ function Public.show(container)
     local left_panel_style = left_panel.style
     left_panel_style.width = 300
 
-    --- @diagnostic disable-next-line invisible
+    --- @diagnostic disable-next-line: access-invisible
     for token_id in pairs(Storage._registered) do
         local header = left_panel.add{ type = "flow" }.add{ type = "label", name = header_name, caption = token_id }
         Gui.set_data(header, token_id)