Refactor some of the Guis from the legacy plugin (#399)

* Fix bugs in core and add default args to Gui defs

* Refactor production Gui

* Refactor landfill blueprint button

* Fix more bugs in core

* Consistent naming of new guis

* Refactor module inserter gui

* Refactor surveillance gui

* Add shorthand for data from arguments

* Make element names consistent

* Add types

* Change how table rows work

* Refactor player stats gui

* Refactor quick actions gui

* Refactor research milestones gui

* Refactor player bonus gui

* Refactor science production gui

* Refactor autofill gui

* Cleanup use of aligned flow

* Rename "Gui.element" to "Gui.define"

* Rename Gui types

* Rename property_from_arg

* Add guide for making guis

* Add full reference document

* Add condensed reference

* Apply style guide to refactored guis

* Bug fixes

exp_legacy/module/modules/gui/rocket-info.lua

@@ -39,12 +39,12 @@ end
 
 --- Button to toggle the auto launch on a rocket silo
 -- @element toggle_launch
-local toggle_launch = Gui.element("toggle_launch")
+local toggle_launch = Gui.define("toggle_launch")
     :draw{
         type = "sprite-button",
         sprite = "utility/play",
         tooltip = { "rocket-info.toggle-rocket-tooltip" },
-        name = Gui.property_from_name,
+        name = Gui.from_name,
     }
     :style(Gui.styles.sprite{
         size = 16,
@@ -65,7 +65,7 @@ local toggle_launch = Gui.element("toggle_launch")
 
 --- XY cords that allow zoom to map when pressed
 -- @element silo_cords
-local silo_cords = Gui.element("silo_cords")
+local silo_cords = Gui.define("silo_cords")
     :draw(function(definition, parent, silo_data)
         local silo_name = silo_data.silo_name
         local pos = silo_data.position
@@ -105,6 +105,8 @@ local silo_cords = Gui.element("silo_cords")
             definition:link_element(label_x)
             definition:link_element(label_y)
         end
+
+        return Gui.no_return()
     end)
     :on_click(function(def, player, element)
         local rocket_silo_name = element.parent.caption
@@ -114,7 +116,7 @@ local silo_cords = Gui.element("silo_cords")
 
 --- Base element for each rocket in the progress list
 -- @element rocket_entry
-local rocket_entry = Gui.element("rocket_entry")
+local rocket_entry = Gui.define("rocket_entry")
     :draw(function(_, parent, silo_data)
         local silo_name = silo_data.silo_name
         local player = Gui.get_player(parent)
@@ -149,7 +151,7 @@ local rocket_entry = Gui.element("rocket_entry")
 
 --- Data label which contains a name and a value label pair
 -- @element data_label
-local data_label = Gui.element("data_label")
+local data_label = Gui.define("data_label")
     :draw(function(_, parent, label_data)
         local data_name = label_data.name
         local data_subname = label_data.subname
@@ -392,14 +394,14 @@ end
 
 -- Button to toggle a section dropdown
 -- @element toggle_section
-local toggle_section = Gui.element("rocket_info_toggle_section")
+local toggle_section = Gui.define("rocket_info_toggle_section")
     :draw{
         type = "sprite-button",
         sprite = "utility/expand",
         hovered_sprite = "utility/expand",
         tooltip = { "rocket-info.toggle-section-tooltip" },
         style = "frame_action_button",
-        name = Gui.property_from_name,
+        name = Gui.from_name,
     }
     :style(Gui.styles.sprite{
         size = 20,
@@ -419,17 +421,16 @@ local toggle_section = Gui.element("rocket_info_toggle_section")
 
 -- Draw a section header and main scroll
 -- @element rocket_list_container
-local section = Gui.element("rocket_info_section")
+local section = Gui.define("rocket_info_section")
     :draw(function(definition, parent, section_name, table_size)
         -- Draw the header for the section
         local header = Gui.elements.header(parent, {
             name = section_name .. "-header",
             caption = { "rocket-info.section-caption-" .. section_name },
             tooltip = { "rocket-info.section-tooltip-" .. section_name },
-            label_name = "label",
         })
 
-        definition:link_element(header.parent.label)
+        definition:link_element(header.label)
 
         -- Right aligned button to toggle the section
         header.caption = section_name
@@ -449,7 +450,7 @@ local section = Gui.element("rocket_info_section")
 
 --- Main gui container for the left flow
 -- @element rocket_list_container
-local rocket_list_container = Gui.element("rocket_list_container")
+local rocket_list_container = Gui.define("rocket_list_container")
     :draw(function(definition, parent)
         -- Draw the internal container
         local container = Gui.elements.container(parent, 200)