From ffccc1590764a1be7b050514f25053cffd5721d2 Mon Sep 17 00:00:00 2001 From: Cooldude2606 Date: Mon, 1 Jan 2018 13:26:44 +0000 Subject: [PATCH 1/3] Added Opt param to Gui.left.update for players --- ExpCore/GuiParts/left.lua | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/ExpCore/GuiParts/left.lua b/ExpCore/GuiParts/left.lua index 20fbee45..3ebe6080 100644 --- a/ExpCore/GuiParts/left.lua +++ b/ExpCore/GuiParts/left.lua @@ -29,10 +29,12 @@ end --- This is used to update all the guis of conected players, good idea to use our thread system as it as nested for loops -- @usage Gui.left.update() --- @tparam string frame this is the name of a frame if you only want to update one -function left.update(frame) +-- @tparam[opt] string frame this is the name of a frame if you only want to update one +-- @param[opt] players the player to update for, if not given all players are updated +function left.update(frame,players) if not Server or not Server._thread then - for _,player in pairs(game.connected_players) do + local players = players and {unpack(players)} or game.connected_players + for _,player in pairs(players) do local frames = Gui._get_data('left') or {} if frame then frames = {[frame]=frames[frame]} or {} end for name,left in pairs(frames) do @@ -45,8 +47,9 @@ function left.update(frame) else local frames = Gui._get_data('left') or {} if frame then frames = {[frame]=frames[frame]} or {} end + local players = players and {unpack(players)} or game.connected_players Server.new_thread{ - data={players=game.connected_players,frames=frames} + data={players=players,frames=frames} }:on_event('tick',function(thread) if #thread.data.players == 0 then thread:close() return end local player = table.remove(thread.data.players,1) From 49b5a9cd8d493573a28d962cf34e0c59cbcdb4f8 Mon Sep 17 00:00:00 2001 From: Cooldude2606 Date: Mon, 1 Jan 2018 13:32:58 +0000 Subject: [PATCH 2/3] Added abilty to have one player --- ExpCore/GuiParts/left.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ExpCore/GuiParts/left.lua b/ExpCore/GuiParts/left.lua index 3ebe6080..b2519a20 100644 --- a/ExpCore/GuiParts/left.lua +++ b/ExpCore/GuiParts/left.lua @@ -33,7 +33,7 @@ end -- @param[opt] players the player to update for, if not given all players are updated function left.update(frame,players) if not Server or not Server._thread then - local players = players and {unpack(players)} or game.connected_players + local players = is_type(players,'table') and #players > 0 and {unpack(players)} or is_type(players,'table') and {players} or game.connected_players for _,player in pairs(players) do local frames = Gui._get_data('left') or {} if frame then frames = {[frame]=frames[frame]} or {} end @@ -47,7 +47,7 @@ function left.update(frame,players) else local frames = Gui._get_data('left') or {} if frame then frames = {[frame]=frames[frame]} or {} end - local players = players and {unpack(players)} or game.connected_players + local players = is_type(players,'table') and #players > 0 and {unpack(players)} or is_type(players,'table') and {players} or game.connected_players Server.new_thread{ data={players=players,frames=frames} }:on_event('tick',function(thread) From fddc6e40d723181f42c6dea80aae8d6df428cb0d Mon Sep 17 00:00:00 2001 From: Cooldude2606 Date: Mon, 1 Jan 2018 13:33:13 +0000 Subject: [PATCH 3/3] Added Extra Comment --- ExpCore/GuiParts/left.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ExpCore/GuiParts/left.lua b/ExpCore/GuiParts/left.lua index b2519a20..98605098 100644 --- a/ExpCore/GuiParts/left.lua +++ b/ExpCore/GuiParts/left.lua @@ -30,7 +30,7 @@ end --- This is used to update all the guis of conected players, good idea to use our thread system as it as nested for loops -- @usage Gui.left.update() -- @tparam[opt] string frame this is the name of a frame if you only want to update one --- @param[opt] players the player to update for, if not given all players are updated +-- @param[opt] players the player to update for, if not given all players are updated, can be one player function left.update(frame,players) if not Server or not Server._thread then local players = is_type(players,'table') and #players > 0 and {unpack(players)} or is_type(players,'table') and {players} or game.connected_players