mirror of
https://github.com/PHIDIAS0303/ExpCluster.git
synced 2026-11-17 00:40:42 +09:00
Address review on exp_server_list
The controller and instance plugins are init functions with closures. The controller batches refreshes with setMany and deleteMany, and the instance gates updates on its status instead of a started flag. short_name is now display_name. New always_on_top field sorts servers first in get_servers. The record carries has_password from the game password in factorio.settings, never the password itself, and the description falls back to the one in factorio.settings. A controller welcome is used when the instance has none, and the readme falls back to a default welcome from the locale. Lua gets is_synced for connect.lua. The readme passes an empty detail instead of nil to the join tooltip so the player count stays in __2__, restores the Password status, shows the welcome title as a centered label and shortens long descriptions with the full text as a tooltip. The Lua tests assert the lookups they index, which fixes the lint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
4d136853c9
commit
c0289ed8a7
15 files changed
+528
-418
No files matched your search
@@ -31,11 +31,13 @@ return Framework.suite(function(env)
|
||||
local server = {
|
||||
id = id,
|
||||
name = "Server " .. id,
|
||||
short_name = "S" .. id,
|
||||
display_name = "S" .. id,
|
||||
description = "",
|
||||
welcome = "",
|
||||
reset_time = "",
|
||||
hidden = false,
|
||||
always_on_top = false,
|
||||
has_password = false,
|
||||
mod_pack_name = "Base",
|
||||
factorio_version = "2.1.14",
|
||||
player_count = 0,
|
||||
|
||||
Reference in new issue
Block a user