mirror of
https://github.com/clusterio/clusterio.git
synced 2026-11-11 23:04:52 +09:00
bbassieandClaude Opus 5
fbdd647168
assignInstance sets instance.assigned_host to the new host before
sending InstanceAssignInternalRequest. If the host fails that request
the controller kept the new host id while the host never added the
instance. Assigning to the same host again then returned early as a
no-op. Repro: make the host's instances directory read-only, assign
instance 3001 to host 10 (EACCES on mkdir), make it writable, assign
again (ok, nothing happens), start (instance does not exist on host).
Now a failed send leaves the instance unassigned and rethrows.
InstanceCreateRequest applied instance.assigned_host from the request
config, creating an instance assigned to a host that never heard of
it. Repro: InstanceCreateRequest({"instance.id": 4001, "instance.name":
"c1", "instance.assigned_host": 10}). Reject a non-null value with the
same error the config set requests use.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
79 lines
2.7 KiB
JavaScript
79 lines
2.7 KiB
JavaScript
import assert from "node:assert/strict";
|
|
import * as lib from "@clusterio/lib";
|
|
import { ControlConnection, InstanceManager } from "@clusterio/controller";
|
|
import { MockController } from "../mock.js";
|
|
|
|
describe("controller/src/ControlConnection", function() {
|
|
describe(".handleControllerRestartRequest()", function() {
|
|
let mockController;
|
|
|
|
beforeEach(function() {
|
|
mockController = {
|
|
canRestart: true,
|
|
shouldRestart: false,
|
|
stopped: false,
|
|
async checkRestartDowngrade() { return null; },
|
|
stop() { this.stopped = true; },
|
|
};
|
|
});
|
|
|
|
async function restart() {
|
|
await ControlConnection.prototype.handleControllerRestartRequest.call({
|
|
_controller: mockController,
|
|
});
|
|
}
|
|
|
|
it("restarts when the installed version is not older", async function() {
|
|
await restart();
|
|
assert.equal(mockController.shouldRestart, true);
|
|
assert.equal(mockController.stopped, true);
|
|
});
|
|
|
|
it("rejects a downgrade without stopping the controller", async function() {
|
|
mockController.checkRestartDowngrade = async () => ({
|
|
installedVersion: "1.0.0",
|
|
runningVersion: "2.0.0",
|
|
});
|
|
|
|
await assert.rejects(restart, /Stop the controller before starting the older version manually/);
|
|
assert.equal(mockController.shouldRestart, false);
|
|
assert.equal(mockController.stopped, false);
|
|
});
|
|
});
|
|
|
|
describe(".handleInstanceCreateRequest()", function() {
|
|
let mockController;
|
|
|
|
beforeEach(function() {
|
|
mockController = new MockController();
|
|
mockController.mockConfigEntries.set("controller.name", "Test");
|
|
mockController.instances = new InstanceManager(new lib.SubscribableDatastore(), mockController);
|
|
});
|
|
|
|
async function create(config, cloneFromId) {
|
|
await ControlConnection.prototype.handleInstanceCreateRequest.call(
|
|
{ _controller: mockController },
|
|
new lib.InstanceCreateRequest(config, cloneFromId),
|
|
);
|
|
}
|
|
|
|
it("rejects instance.assigned_host in the config", async function() {
|
|
await assert.rejects(
|
|
create({ "instance.id": 4001, "instance.name": "c1", "instance.assigned_host": 10 }),
|
|
new lib.RequestError("instance.assigned_host must be set through the assign-host interface"),
|
|
);
|
|
assert.equal(mockController.instances.has(4001), false);
|
|
});
|
|
|
|
it("creates an unassigned clone of an assigned instance", async function() {
|
|
await create({ "instance.id": 4001, "instance.name": "base" });
|
|
mockController.instances.getMutable(4001).config.set("instance.assigned_host", 10);
|
|
|
|
await create({ "instance.id": 4002, "instance.name": "clone", "instance.assigned_host": null }, 4001);
|
|
const clone = mockController.instances.get(4002);
|
|
assert.equal(clone.config.get("instance.name"), "clone");
|
|
assert.equal(clone.config.get("instance.assigned_host"), null);
|
|
});
|
|
});
|
|
});
|