mirror of
https://github.com/clusterio/clusterio.git
synced 2026-11-11 23:04:52 +09:00
bbassieandClaude Opus 5
cf4e85c6ee
Log messages share the root cause with the save details updates fixed in the previous commit: the controller trusted host supplied instance fields. LogMessageEvent only declares level and message in its schema, but the Ajv instance is built without removeAdditional and the schema does not set additionalProperties, so instance_id and instance_name sent by a host survive validation and pass through fromJSON untouched. A host could tag a log line with an instance assigned to another host and have the controller store and serve it as that instance's output. Lift the assignment check out of handleInstanceSaveDetailsUpdatesEvent into a private method and use it from both handlers. Strip the instance fields instead of dropping the line. A host racing a reassignment does emit instance log lines for an instance the controller has already moved, and dropping those loses real output exactly when a migration is going wrong. The line is still genuine output from the host, so it is recorded as a host level message, which grants the host nothing it could not already log directly. Warn once per connection so a misbehaving host cannot flood the log. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>