mirror of
https://github.com/clusterio/clusterio.git
synced 2026-11-12 07:04:52 +09:00
Hornwitser
e453a80155
Use the JSON data class pattern for User, Role, and PlayerStats and move them into lib/src/data. This means that User is purely data now and can't reference role objects directly. To make it possible easily check permissions attached to roles and store data only visible on the controller on user objects a ControllerUser type is introduced which is linked with the UserManager and can therefore reference role objects directly. Resolves #525.
51 lines
2.2 KiB
JavaScript
51 lines
2.2 KiB
JavaScript
"use strict";
|
|
const assert = require("assert").strict;
|
|
const { ControllerUser } = require("@clusterio/controller");
|
|
const lib = require("@clusterio/lib");
|
|
|
|
describe("controller/src/ControllerUser", function() {
|
|
describe("class ControllerUser", function() {
|
|
class MockUserManager {
|
|
roles = new Map([
|
|
[1, new lib.Role(1, "a", "a role", new Set(["core.admin"]))],
|
|
[2, new lib.Role(2, "b", "b role", new Set(["user-test"]))],
|
|
]);
|
|
}
|
|
const userManager = new MockUserManager();
|
|
|
|
it("should round trip serialize", function() {
|
|
function test_roundtrip(serialized) {
|
|
let user = ControllerUser.fromJSON(serialized, userManager);
|
|
let user_serialized = user.toJSON(true);
|
|
assert.deepEqual(user_serialized, serialized);
|
|
let user_deserialized = ControllerUser.fromJSON(user_serialized, userManager);
|
|
assert.deepEqual(user_deserialized, user);
|
|
}
|
|
|
|
test_roundtrip({ name: "admin", roles: [1] });
|
|
test_roundtrip({ name: "user", roles: [2], token_valid_after: 12345 });
|
|
test_roundtrip({ name: "user", is_admin: true, is_whitelisted: true });
|
|
test_roundtrip({ name: "user", is_banned: true, ban_reason: "Bad user" });
|
|
test_roundtrip({ name: "user", instance_stats: [[1, { join_count: 1 }]]});
|
|
});
|
|
describe(".checkPermission()", function() {
|
|
it("should correctly resolve permissions", function() {
|
|
lib.definePermission({ name: "user-test", title: "Test", description: "User Test" });
|
|
let a = ControllerUser.fromJSON({ name: "admin", roles: [1] }, userManager);
|
|
let b = ControllerUser.fromJSON({ name: "user", roles: [2] }, userManager);
|
|
let c = ControllerUser.fromJSON({ name: "null", roles: [] }, userManager);
|
|
|
|
a.checkPermission("core.control.connect");
|
|
assert.throws(() => b.checkPermission("core.control.connect"), new Error("Permission denied"));
|
|
assert.throws(() => c.checkPermission("core.control.connect"), new Error("Permission denied"));
|
|
|
|
a.checkPermission("user-test");
|
|
b.checkPermission("user-test");
|
|
assert.throws(() => c.checkPermission("user-test"), new Error("Permission denied"));
|
|
|
|
assert.throws(() => a.checkPermission("invalid"), new Error("permission invalid does not exist"));
|
|
});
|
|
});
|
|
});
|
|
});
|