mirror of
https://github.com/clusterio/clusterio.git
synced 2026-11-13 15:14:52 +09:00
bbassieandClaude Opus 4.8
70305b7937
execFile was called with shell: true and an array of arguments, which Node deprecates in DEP0190 because it concatenates the arguments by space without escaping anything, giving the impression they have been made safe. The warning was printed to the console on every install. The arguments here are already escaped for the shell by escapeArg, so join them into the command instead of handing them to execFile to concatenate. Nothing about what ends up being run changes. Point the escaping test at the same form so it covers what the installer actually does, and stops emitting the warning itself. Its several hundred round trip cases still pass, which is what confirms the escaping is unaffected. Fixes #851 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>