mirror of
https://github.com/clusterio/clusterio.git
synced 2026-11-13 23:14:53 +09:00
bbassieandClaude Opus 4.8
5b769adcc5
handleInstanceSaveDetailsUpdatesEvent trusted the instanceId in the event and in each SaveDetails without checking the instance was assigned to the sending host. InstanceSaveDetailsUpdatesEvent has host in its src list and validateIngress only checks the source host id, not the payload, so any authenticated host could corrupt another instance's controller-side save records. Repro: a host owning nothing sends the event with a SaveDetails for instance 1002 (on another host) to inject a bogus save, or sends empty updates with instanceId 1002 to make the delete-missing sweep wipe that instance's save list. Guard both paths: bail if event.instanceId names an instance not assigned to this host, and drop the whole event if any update is for an instance not assigned here. Matches handleInstanceStatusChangedEvent's bogus-update warning. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
79 lines
2.8 KiB
JavaScript
79 lines
2.8 KiB
JavaScript
import assert from "node:assert/strict";
|
|
import * as lib from "@clusterio/lib";
|
|
import { HostConnection } from "@clusterio/controller";
|
|
|
|
function makeSave(instanceId, name) {
|
|
return new lib.SaveDetails(instanceId, "file", name, 0, 0, false, false, 0, false);
|
|
}
|
|
|
|
// Mock saves datastore backed by a Map keyed on SaveDetails.id.
|
|
class MockSaves {
|
|
constructor(saves = []) {
|
|
this.saves = new Map(saves.map(s => [s.id, s]));
|
|
}
|
|
|
|
get(id) { return this.saves.get(id); }
|
|
|
|
values() { return this.saves.values(); }
|
|
|
|
setMany(saves) { for (const s of saves) { this.saves.set(s.id, s); } }
|
|
|
|
deleteMany(saves) { for (const s of saves) { this.saves.delete(s.id); } }
|
|
}
|
|
|
|
// Mock instances manager where instance id -> assigned host id.
|
|
function makeInstances(assignments) {
|
|
return {
|
|
get(id) {
|
|
if (!assignments.has(id)) {
|
|
return undefined;
|
|
}
|
|
const host = assignments.get(id);
|
|
return { config: { get: name => (name === "instance.assigned_host" ? host : undefined) } };
|
|
},
|
|
};
|
|
}
|
|
|
|
describe("controller/src/HostConnection", function() {
|
|
describe(".handleInstanceSaveDetailsUpdatesEvent()", function() {
|
|
// Instance 1 is on host 10, instance 2 is on host 20.
|
|
const assignments = new Map([[1, 10], [2, 20]]);
|
|
|
|
function run(hostId, saves, event) {
|
|
const saveStore = new MockSaves(saves);
|
|
const ctx = {
|
|
id: hostId,
|
|
_controller: { instances: makeInstances(assignments), saves: saveStore },
|
|
};
|
|
HostConnection.prototype.handleInstanceSaveDetailsUpdatesEvent.call(ctx, event);
|
|
return saveStore;
|
|
}
|
|
|
|
it("applies updates for an instance assigned to this host", async function() {
|
|
const store = run(10, [], new lib.InstanceSaveDetailsUpdatesEvent([makeSave(1, "a.zip")], 1));
|
|
assert.deepEqual([...store.values()].map(s => s.id), ["1/a.zip"]);
|
|
});
|
|
|
|
it("sweeps missing saves for an instance assigned to this host", async function() {
|
|
const store = run(10, [makeSave(1, "old.zip")], new lib.InstanceSaveDetailsUpdatesEvent([], 1));
|
|
assert.deepEqual([...store.values()], []);
|
|
});
|
|
|
|
it("ignores injected saves for an instance on another host", async function() {
|
|
const store = run(30, [], new lib.InstanceSaveDetailsUpdatesEvent([makeSave(1, "HACKED.zip")]));
|
|
assert.deepEqual([...store.values()], [], "foreign save must not be stored");
|
|
});
|
|
|
|
it("ignores a wipe of an instance on another host", async function() {
|
|
const existing = makeSave(1, "keep.zip");
|
|
const store = run(30, [existing], new lib.InstanceSaveDetailsUpdatesEvent([], 1));
|
|
assert.deepEqual([...store.values()].map(s => s.id), ["1/keep.zip"], "existing save must survive");
|
|
});
|
|
|
|
it("ignores updates for a nonexistent instance", async function() {
|
|
const store = run(30, [], new lib.InstanceSaveDetailsUpdatesEvent([makeSave(999, "x.zip")]));
|
|
assert.deepEqual([...store.values()], []);
|
|
});
|
|
});
|
|
});
|