mirror of
https://github.com/clusterio/clusterio.git
synced 2026-11-17 07:30:41 +09:00
Address review of template inheritance
- Unlinking a field enables Apply on its own and sends the current value. - The link button no longer toggles the checkbox of its label. - Link and disconnect icons for all four states, pending ones highlighted. - instance.is_template is hidden. - ctl create takes --as-template. - Clearer names for the InstanceManager inheritance helpers. Part of #200 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
943619a657
commit
f14bfc3222
8 files changed
+68
-59
No files matched your search
@@ -978,7 +978,7 @@ describe("Integration of Clusterio", function() {
|
||||
}
|
||||
});
|
||||
it("creates a template and an instance inheriting from it", async function() {
|
||||
await execCtl("instance create inheritTemplate --id 4400 --is-template");
|
||||
await execCtl("instance create inheritTemplate --id 4400 --as-template");
|
||||
await execCtl("instance config set inheritTemplate factorio.version 2.0");
|
||||
await execCtl("instance create inheritChild --id 4401 --template inheritTemplate");
|
||||
const config = await getControl().send(new lib.InstanceConfigGetRequest(4401));
|
||||
@@ -998,7 +998,7 @@ describe("Integration of Clusterio", function() {
|
||||
assert.equal(config["factorio.settings"].afk_autokick_interval, 9);
|
||||
});
|
||||
it("creates a template from an existing instance", async function() {
|
||||
await execCtl("instance create inheritCopy --id 4403 --is-template --from 4401");
|
||||
await execCtl("instance create inheritCopy --id 4403 --as-template --from 4401");
|
||||
const config = await getControl().send(new lib.InstanceConfigGetRequest(4403));
|
||||
assert.equal(config["instance.is_template"], true);
|
||||
assert.equal(config["factorio.settings"].max_players, 3);
|
||||
@@ -1011,7 +1011,7 @@ describe("Integration of Clusterio", function() {
|
||||
});
|
||||
it("rejects assigning a template to a host", async function() {
|
||||
await assert.rejects(
|
||||
execCtl("instance assign inheritTemplate 4"),
|
||||
execCtl(`instance assign inheritTemplate ${hostId}`),
|
||||
new lib.ValidationError("Templates cannot be assigned to a host"),
|
||||
);
|
||||
});
|
||||
|
||||
Reference in new issue
Block a user