From ed4fe3230d5307d51b5bd537990ad19e953710b7 Mon Sep 17 00:00:00 2001 From: Cooldude2606 <25043174+Cooldude2606@users.noreply.github.com> Date: Wed, 18 Mar 2026 00:03:44 +0000 Subject: [PATCH] Fixed test causing missed coverage --- test/lib/config/classes.js | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/test/lib/config/classes.js b/test/lib/config/classes.js index 291bdd98..12a8f1bd 100644 --- a/test/lib/config/classes.js +++ b/test/lib/config/classes.js @@ -46,11 +46,15 @@ describe("lib/config/classes", function() { "test.dependent": { type: "number", initialValue: 1, - dependsOn: ["test.base"], + dependsOn: ["test.base", "test.objDependent"], validator(value, config) { if (value < config.get("test.base")) { throw new Error("dependent must be >= base"); } + const dep = config.get("test.objDependent")?.base; + if (dep === 0) { + throw new Error("objDependent cannot be 0"); + } }, }, "test.objDependent": { @@ -58,7 +62,7 @@ describe("lib/config/classes", function() { initialValue: {}, dependsOn: ["test.base"], validator(value, config) { - if (value.base !== undefined && value.base !== config.get("test.base")) { + if (value.base && value.base !== config.get("test.base")) { throw new Error("base prop must match test.base"); } }, @@ -867,9 +871,10 @@ describe("lib/config/classes", function() { assert.deepEqual(testInstance.get("test.objDependent"), { base: 1 }); }); it("should throw if dependent validation fails", function() { + testInstance.set("test.base", 0); assert.throws( - () => testInstance.setProp("test.objDependent", "base", 5), - new lib.InvalidValue("Failed validation of test.objDependent: base prop must match test.base") + () => testInstance.setProp("test.objDependent", "base", 0), + new lib.InvalidValue("Failed validation of dependent test.dependent: objDependent cannot be 0") ); }); });