From e6add2f7e606842413322953f9f37f91e8e13df8 Mon Sep 17 00:00:00 2001 From: Hornwitser Date: Sat, 15 Oct 2022 17:59:38 +0200 Subject: [PATCH] Fix handling of numeric settings in ModPackViewPage Due to a mistake in the logic numeric settings would end up getting converted to string settings when edited. --- packages/web_ui/src/components/ModPackViewPage.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/web_ui/src/components/ModPackViewPage.jsx b/packages/web_ui/src/components/ModPackViewPage.jsx index 981b4881..4507f534 100644 --- a/packages/web_ui/src/components/ModPackViewPage.jsx +++ b/packages/web_ui/src/components/ModPackViewPage.jsx @@ -497,13 +497,13 @@ export default function ModPackViewPage() { } else if (["startup", "runtime-global", "runtime-per-user"].includes(field.name[0])) { let [scope, settingName] = field.name; let value = field.value; - if (typeof modPack.settings[scope].get(settingName) === "number") { + if (typeof modPack.settings[scope].get(settingName).value === "number") { value = Number(value); if (Number.isNaN(value)) { continue; } } - if (modifiedModPack.settings[scope].get(settingName) !== value) { + if (modifiedModPack.settings[scope].get(settingName).value !== value) { pushChange({ type: "settings.set", scope, name: settingName, value: { value }}); } }