From e5582b5558fc5cd920b3bb9242743fe5d0fec065 Mon Sep 17 00:00:00 2001
From: Hornwitser <github@hornwitser.no>
Date: Tue, 28 Sep 2021 21:36:28 +0200
Subject: [PATCH] Skip gatherng metrics from dropped slaves

Avoid stacking up huge amounts of metrics requests while a slave
connection is in the dropped state.
---
 packages/master/src/routes.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/packages/master/src/routes.js b/packages/master/src/routes.js
index 1ab57577..749b2b55 100644
--- a/packages/master/src/routes.js
+++ b/packages/master/src/routes.js
@@ -48,6 +48,9 @@ async function getMetrics(req, res, next) {
 	let requests = [];
 	let timeout = req.app.locals.master.config.get("master.metrics_timeout") * 1000;
 	for (let slaveConnection of req.app.locals.master.wsServer.slaveConnections.values()) {
+		if (!slaveConnection.connected) {
+			continue;
+		}
 		requests.push(libHelpers.timeout(
 			libLink.messages.getMetrics.send(slaveConnection).catch(err => {
 				if (!(err instanceof libErrors.SessionLost)) {