Use factory pattern for yargs

The ESM import of yargs does not support the singleton way of using
yargs, instead we have to call the yargs function to get a parser that
can be augmented with the options.

The .argv property has also been deprecated. Replace it with a call to
.parse() instead.
This commit is contained in:
Hornwitser committed 2026-09-11 19:51:15 +02:00
1 parent 7987a5d925
commit d6dce12acc
4 files changed
+8 -8

No files matched your search

+2 -2
View File
@@ -268,7 +268,7 @@ interface InitializeParameters {
async function initialize(): Promise<InitializeParameters> { async function initialize(): Promise<InitializeParameters> {
// argument parsing // argument parsing
const args = await yargs const args = await yargs(process.argv.slice(2))
.scriptName("controller") .scriptName("controller")
.usage("$0 <command> [options]") .usage("$0 <command> [options]")
.option("log-level", { .option("log-level", {
@@ -340,7 +340,7 @@ async function initialize(): Promise<InitializeParameters> {
}) })
.demandCommand(1, "You need to specify a command to run") .demandCommand(1, "You need to specify a command to run")
.strict() .strict()
.argv .parse()
; ;
// Combined log stream of the whole cluster. // Combined log stream of the whole cluster.
+3 -3
View File
@@ -750,7 +750,7 @@ async function inquirerMissingArgs(args) {
} }
async function main() { async function main() {
let args = yargs let yarg = yargs(process.argv.slice(2))
.option("log-level", { .option("log-level", {
nargs: 1, describe: "Log level to print to stdout", default: "info", nargs: 1, describe: "Log level to print to stdout", default: "info",
choices: ["none"].concat(Object.keys(levels)), type: "string", choices: ["none"].concat(Object.keys(levels)), type: "string",
@@ -805,14 +805,14 @@ async function main() {
; ;
if (process.platform === "linux") { if (process.platform === "linux") {
args = args yarg = yarg
.option("allow-install-as-root", { .option("allow-install-as-root", {
nargs: 0, describe: "(Linux only) Allow installing as root (not recommended)", type: "boolean", nargs: 0, describe: "(Linux only) Allow installing as root (not recommended)", type: "boolean",
}) })
; ;
} }
args = args.argv; const args = yarg.parse();
setLogLevel(args.logLevel === "none" ? -1 : levels[args.logLevel]); setLogLevel(args.logLevel === "none" ? -1 : levels[args.logLevel]);
dev = args.dev; dev = args.dev;
+1 -1
View File
@@ -82,7 +82,7 @@ export class HostConnector extends lib.WebSocketClientConnector {
async function startHost() { async function startHost() {
// argument parsing // argument parsing
// eslint-disable-next-line node/no-sync // eslint-disable-next-line node/no-sync
const args = yargs const args = yargs(process.argv.slice(2))
.scriptName("host") .scriptName("host")
.usage("$0 <command> [options]") .usage("$0 <command> [options]")
.option("log-level", { .option("log-level", {
+2 -2
View File
@@ -121,7 +121,7 @@ async function build(args) {
async function main() { async function main() {
const args = yargs const args = yargs(process.argv.slice(2))
.scriptName("build") .scriptName("build")
.options({ .options({
"clean": { describe: "Remove previous builds", type: "boolean", default: false }, "clean": { describe: "Remove previous builds", type: "boolean", default: false },
@@ -144,7 +144,7 @@ async function main() {
}, },
}) })
.strict() .strict()
.argv .parse()
; ;
await build(args); await build(args);