From d2fb33f8b9aa81c73313c94403e71b9d94f2e93a Mon Sep 17 00:00:00 2001 From: Hornwitser Date: Fri, 17 Apr 2020 16:15:34 +0200 Subject: [PATCH] Fix log spam by subspace_storage plugin Fix log spam when the dole distribution method is used on subspace_storage plugin. This was caused by a bogus if condition being translated into a sensible but wrong one. --- plugins/subspace_storage/dole.js | 3 ++- plugins/subspace_storage/master.js | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/plugins/subspace_storage/dole.js b/plugins/subspace_storage/dole.js index 5a4d9306..f7ed8dc2 100644 --- a/plugins/subspace_storage/dole.js +++ b/plugins/subspace_storage/dole.js @@ -94,6 +94,7 @@ let _doleDivisionFactor = {}; function doleDivider({ object, items, + logItemTransfers, }){ let itemCount = items.getItemCount(object.name); const doleDivisionRetardation = 10; //lower rates will equal more dramatic swings @@ -102,7 +103,7 @@ function doleDivider({ const originalCount = Number(object.count) || 0; object.count /= ((_doleDivisionFactor[object.name]||0)+doleDivisionRetardation)/doleDivisionRetardation; object.count = Math.round(object.count); - if (itemCount > 40) { + if (logItemTransfers) { console.info(`Serving ${object.count}/${originalCount} ${object.name} from ${itemCount} ${object.name} with dole division factor ${(_doleDivisionFactor[object.name]||0)} (real=${((_doleDivisionFactor[object.name]||0)+doleDivisionRetardation)/doleDivisionRetardation}), item is ${itemCount > object.count?'stocked':'short'}.`); } diff --git a/plugins/subspace_storage/master.js b/plugins/subspace_storage/master.js index 21e44938..64a10a3b 100644 --- a/plugins/subspace_storage/master.js +++ b/plugins/subspace_storage/master.js @@ -139,6 +139,7 @@ class MasterPlugin extends plugin.BaseMasterPlugin { let count = dole.doleDivider({ object: { name: item[0], count: item[1], instanceId, instanceName}, items: this.items, + logItemTransfers: this.master.config.get("subspace_storage.log_item_transfers"), }); if (count > 0) { itemsRemoved.push([item[0], count]);