From c3c2528c30294ed5b20c0889d3d8a78f5e4e6212 Mon Sep 17 00:00:00 2001 From: Hornwitser Date: Sat, 20 Jan 2024 02:44:55 +0100 Subject: [PATCH] Add missing updates to instance.updatedAt Fix instances not properly updating their status to unassigned and unknown due to the updatedAt field not being updated with the current timestamp. --- packages/controller/src/Controller.ts | 1 + packages/controller/src/HostConnection.ts | 2 ++ 2 files changed, 3 insertions(+) diff --git a/packages/controller/src/Controller.ts b/packages/controller/src/Controller.ts index 89214e0f..4ad9e6f0 100644 --- a/packages/controller/src/Controller.ts +++ b/packages/controller/src/Controller.ts @@ -937,6 +937,7 @@ export default class Controller { ); } else { instance.status = "unassigned"; + instance.updatedAt = Date.now(); this.instanceDetailsUpdated([instance]); } } diff --git a/packages/controller/src/HostConnection.ts b/packages/controller/src/HostConnection.ts index f4cf1d84..ec078553 100644 --- a/packages/controller/src/HostConnection.ts +++ b/packages/controller/src/HostConnection.ts @@ -57,6 +57,7 @@ export default class HostConnection extends BaseConnection { } this.connector.on("close", () => { + const now = Date.now(); // Update status to unknown for instances on this host. const instances: InstanceInfo[] = []; for (let instance of this._controller.instances.values()) { @@ -67,6 +68,7 @@ export default class HostConnection extends BaseConnection { instances.push(instance); let prev = instance.status; instance.status = "unknown"; + instance.updatedAt = now; lib.invokeHook(this._controller.plugins, "onInstanceStatusChanged", instance, prev); } this._controller.instanceDetailsUpdated(instances);