mirror of
https://github.com/clusterio/clusterio.git
synced 2026-11-18 23:33:12 +09:00
Quote the expected text in changelog check messages
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
cd7c850a16
commit
c2e08540d0
3 files changed
+5
-5
No files matched your search
@@ -15,7 +15,7 @@ const expectedFormat = [
|
|||||||
"Or, when nothing user facing changed, replace the code block with:",
|
"Or, when nothing user facing changed, replace the code block with:",
|
||||||
"",
|
"",
|
||||||
"### Changelog",
|
"### Changelog",
|
||||||
"None. Only changes CI configuration.",
|
"None. Reason no change log is required.",
|
||||||
].join("\n");
|
].join("\n");
|
||||||
|
|
||||||
/** Returns the problems found in the body, an empty list means it is valid. */
|
/** Returns the problems found in the body, an empty list means it is valid. */
|
||||||
|
|||||||
@@ -79,7 +79,7 @@ function extractPullRequestChangelog(
|
|||||||
{
|
{
|
||||||
const headerFail = skipToLine(parser, /^###? Changelog *$/);
|
const headerFail = skipToLine(parser, /^###? Changelog *$/);
|
||||||
if (headerFail) {
|
if (headerFail) {
|
||||||
return [failure, , "### Changelog header not found"];
|
return [failure, , "\"### Changelog\" header not found"];
|
||||||
}
|
}
|
||||||
parser.pos += 1;
|
parser.pos += 1;
|
||||||
skipEmptyLines(parser);
|
skipEmptyLines(parser);
|
||||||
@@ -99,7 +99,7 @@ function extractPullRequestChangelog(
|
|||||||
}
|
}
|
||||||
const lines = parser.lines.slice(blockStartPos, parser.pos);
|
const lines = parser.lines.slice(blockStartPos, parser.pos);
|
||||||
if (!lines.some(line => line.trim() !== "")) {
|
if (!lines.some(line => line.trim() !== "")) {
|
||||||
return [failure, , "Code block is empty, replace it with None. if nothing applies"];
|
return [failure, , "Code block is empty, replace it with \"None.\" if nothing applies"];
|
||||||
}
|
}
|
||||||
return [success, lines];
|
return [success, lines];
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -30,11 +30,11 @@ describe("scripts/check_pr_changelog", function() {
|
|||||||
});
|
});
|
||||||
it("rejects a missing body or section", function() {
|
it("rejects a missing body or section", function() {
|
||||||
assert.deepEqual(findChangelogProblems(null), ["Pull request has no body"]);
|
assert.deepEqual(findChangelogProblems(null), ["Pull request has no body"]);
|
||||||
assert.deepEqual(findChangelogProblems("Description only."), ["### Changelog header not found"]);
|
assert.deepEqual(findChangelogProblems("Description only."), ["\"### Changelog\" header not found"]);
|
||||||
assert.deepEqual(findChangelogProblems(body("Text")), ["Code block not found after header"]);
|
assert.deepEqual(findChangelogProblems(body("Text")), ["Code block not found after header"]);
|
||||||
assert.deepEqual(findChangelogProblems(body("```", "### Fixes")), ["End of code block not found after header"]);
|
assert.deepEqual(findChangelogProblems(body("```", "### Fixes")), ["End of code block not found after header"]);
|
||||||
assert.deepEqual(findChangelogProblems(body("```", "", "```")), [
|
assert.deepEqual(findChangelogProblems(body("```", "", "```")), [
|
||||||
"Code block is empty, replace it with None. if nothing applies",
|
"Code block is empty, replace it with \"None.\" if nothing applies",
|
||||||
]);
|
]);
|
||||||
});
|
});
|
||||||
it("rejects None. inside the code block", function() {
|
it("rejects None. inside the code block", function() {
|
||||||
|
|||||||
Reference in new issue
Block a user