Give templates their own table and keep rcon_password per instance

The templates table shows name, inheritor count and a create instance
action instead of the instance status and start/stop columns.
factorio.rcon_password joins the ports as never inherited.

Part of #200

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
bbassieandClaude Opus 5.5 committed 2026-11-02 11:54:37 +00:00
1 parent b5c372f109
commit b584991f5c
6 files changed
+66 -11

No files matched your search

+4 -1
View File
@@ -433,11 +433,14 @@ describe("controller/InstanceManager", function () {
assert.equal(child.config.isInherited("factorio.game_port"), false);
assert.equal(child.config.isInherited("instance.name"), false);
});
it("should never inherit ports", function () {
it("should never inherit ports or the rcon password", function () {
template.config.set("factorio.rcon_password", "secret");
const config = new lib.InstanceConfig("controller", { "instance.id": 12, "instance.template_id": 10 });
instances.applyTemplate(config, ["instance.id", "instance.template_id"]);
assert.equal(config.get("factorio.game_port"), null);
assert.equal(config.isInherited("factorio.game_port"), false);
assert.equal(config.get("factorio.rcon_password"), null);
assert.equal(config.isInherited("factorio.rcon_password"), false);
});
it("should inherit factorio.settings per property with its own server name", function () {
const settings = child.config.get("factorio.settings");
+2 -1
View File
@@ -14,7 +14,8 @@ describe("lib/config/definitions", function() {
for (const name of [
"instance.name", "instance.id", "instance.assigned_host", "instance.is_template",
"instance.template_id", "instance.inherited_fields", "factorio.host_assigned_game_port",
"factorio.game_port", "factorio.rcon_port", "factorio.lua_udp_port", "no.field",
"factorio.game_port", "factorio.rcon_port", "factorio.rcon_password", "factorio.lua_udp_port",
"no.field",
]) {
assert.equal(lib.InstanceConfig.isInheritable(name), false, name);
}