From b019d44d0bd077c184108b11a5273361fefd4596 Mon Sep 17 00:00:00 2001 From: Hornwitser Date: Tue, 7 Sep 2021 03:19:47 +0200 Subject: [PATCH] Fix active connectors leaking after refactor The activeConnectors mapping is from session id to connector, but the master refactor in 67219ed accidentally changed it to try deleting the entry by the connector reference instead. Possibly mistaking it for a Set instead of a Map. --- packages/master/src/WsServer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/master/src/WsServer.js b/packages/master/src/WsServer.js index 3c9b0238..ea0ada5f 100644 --- a/packages/master/src/WsServer.js +++ b/packages/master/src/WsServer.js @@ -258,7 +258,7 @@ ${err.stack}` let connector = new WsServerConnector(sessionId, sessionTimeout, heartbeatInterval); this.activeConnectors.set(sessionId, connector); connector.on("close", () => { - this.activeConnectors.delete(connector); + this.activeConnectors.delete(sessionId); }); let additionalReadyData = {};