From 9a032aed2e37e67233911de032e1361ea9d364de Mon Sep 17 00:00:00 2001 From: Hornwitser Date: Wed, 21 Aug 2019 19:17:16 +0200 Subject: [PATCH] Backport use Node.js version 10 Update instructions, Dockerfile and Travis CI to use Node.js 10. Specify that Node.js version 10 or greater is needed in the engines section of package.json (note that this is only advisory.) And document this as a breaking change in CHANGELOG.md. This is a backport of 69a1ff7. --- .travis.yml | 2 +- CHANGELOG.md | 4 ++++ Dockerfile | 2 +- README.md | 4 ++-- package.json | 3 +++ 5 files changed, 11 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 93725d69..6c6cdd0a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,6 +1,6 @@ language: node_js node_js: - - "9" + - 10 before_install: - sudo apt-get -qq update - sudo apt-get install -y curl git tar diff --git a/CHANGELOG.md b/CHANGELOG.md index b4c038bf..2a3faefe 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,6 +19,10 @@ Version 1.2.2 - Swapped curl out with wget in the install instructions as the latter comes pre-installed on Ubuntu. +### Breaking Changes + +- Node.js versions below 10 are no longer supported. + Version 1.2.1 ------------- diff --git a/Dockerfile b/Dockerfile index b754a329..17f2bb2e 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM node:9.11.2 +FROM node:10 RUN apt-get update && apt install git curl tar -y RUN mkdir factorioClusterio diff --git a/README.md b/README.md index 7f4b5f26..ac480c94 100644 --- a/README.md +++ b/README.md @@ -95,7 +95,7 @@ NodeJS does not support EOL ubuntu releases. Make sure you are on the most recen Master and all slaves: - wget -O - https://deb.nodesource.com/setup_9.x | sudo -E bash - + wget -O - https://deb.nodesource.com/setup_10.x | sudo -E bash - sudo apt install -y nodejs python-dev git build-essential git clone -b 1.2.x https://github.com/Danielv123/factorioClusterio.git cd factorioClusterio @@ -168,7 +168,7 @@ Game Client = The people connecting to the server **Requirements** -download and install nodeJS 8 or 9 from http://nodejs.org +download and install nodeJS 10 from http://nodejs.org download and install git from https://git-scm.com/ diff --git a/package.json b/package.json index a28335c6..d6172335 100644 --- a/package.json +++ b/package.json @@ -16,6 +16,9 @@ ], "author": "Danielv123", "license": "MIT", + "engines": { + "node": ">=10" + }, "dependencies": { "as-table": "^1.0.31", "averaged-timeseries": "^1.4.0",