Refactor getFactorioLocale

Move getFactorioLocale to the new lib/factorio namespace and refactor it
to use async functions instead of callbacks.  Split tests into
integration with factorio and testing of the function itself.

Also removes the cacheing from the function itself as this breaks the
isolated testing of it.
This commit is contained in:
Hornwitser committed 2019-10-14 18:56:46 +02:00
1 parent a01b971ba2
commit 93480c8b29
8 files changed
+125 -132

No files matched your search

+18
View File
@@ -0,0 +1,18 @@
const assert = require("assert").strict;
const path = require("path");
const factorio = require("lib/factorio");
describe("lib/factorio/locale", function() {
describe("getLocale()", function() {
it("verifies types of the arguments", async function() {
await assert.rejects(factorio.getLocale(1, "a"), new TypeError("dataDir must be a string"));
await assert.rejects(factorio.getLocale("a", 1), new TypeError("languageCode must be a string"));
});
it("returns a nested object with locale definitions", async function() {
let locale = await factorio.getLocale(path.join("test", "file", "factorio", "data"), "en");
assert.deepEqual(locale, { test: { "key-a": "1", "key-b": "2" } });
});
});;
});