From 916c48844aa67f3976db6033811fa128a932e88a Mon Sep 17 00:00:00 2001 From: Cooldude2606 <25043174+Cooldude2606@users.noreply.github.com> Date: Sun, 6 Apr 2025 18:06:05 +0100 Subject: [PATCH] Fix incorrect use of Array.splice This should resolve the sync loops for bans and admins --- packages/host/src/Instance.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/host/src/Instance.ts b/packages/host/src/Instance.ts index 71a96343..139fbde2 100644 --- a/packages/host/src/Instance.ts +++ b/packages/host/src/Instance.ts @@ -1036,7 +1036,7 @@ end`.replace(/\r?\n/g, " "); expected => expected.name === name && expected.action === action && expected.reason === reason ); if (expectedIndex >= 0) { - this._expectedUserUpdates = this._expectedUserUpdates.splice(expectedIndex, 1); + this._expectedUserUpdates.splice(expectedIndex, 1); } else if (action === "BAN") { if (this.config.get("factorio.sync_banlist") !== "bidirectional") { return; } this.sendTo(addr, new lib.InstanceBanlistUpdateEvent(name, true, reason ?? ""));