Provide control at init time for web plugins

The control interface is required for adding handlers for message types
a plugin defines, but the plugins were loaded before the Control
instance was created. This meant there was no sensible way for web
plugins to register handlers for their own message types.

Move the creating of the Control instance to before plugins are loaded
and set this.control for web plugins before init is called.
This commit is contained in:
Hornwitser committed 2023-11-28 15:35:40 +01:00
1 parent 70d2b319b3
commit 8c724e3bc5
4 files changed
+17 -16

No files matched your search

+5 -5
View File
@@ -67,8 +67,8 @@ async function loadPluginInfos(): Promise<lib.PluginWebpackEnvInfo[]> {
return pluginInfos;
}
async function loadPlugins(pluginInfos: lib.PluginWebpackEnvInfo[]) {
let plugins = new Map();
async function loadPlugins(pluginInfos: lib.PluginWebpackEnvInfo[], control: Control) {
let plugins = new Map<string, BaseWebPlugin>();
for (let pluginInfo of pluginInfos) {
if (!pluginInfo.enabled) {
continue;
@@ -83,7 +83,7 @@ async function loadPlugins(pluginInfos: lib.PluginWebpackEnvInfo[]) {
WebPluginClass = webModule.WebPlugin;
}
let plugin = new WebPluginClass(pluginInfo.container, pluginInfo.package, pluginInfo, logger);
let plugin = new WebPluginClass(pluginInfo.container, pluginInfo.package, pluginInfo, control, logger);
await plugin.init();
plugins.set(pluginInfo.name, plugin);
@@ -106,11 +106,11 @@ export default async function bootstrap() {
lib.registerPluginMessages(pluginInfos);
lib.registerPluginConfigGroups(pluginInfos);
lib.finalizeConfigs();
let plugins = await loadPlugins(pluginInfos);
let wsUrl = new URL(webRoot, document.location.href);
let controlConnector = new ControlConnector(wsUrl.href, 120, undefined);
let control = new Control(controlConnector, plugins);
let control = new Control(controlConnector);
control.plugins = await loadPlugins(pluginInfos, control);
const root = createRoot(document.getElementById("root") as HTMLDivElement);
root.render(<App control={control}/>);