From 870e1f2125ebf00da59ef2271bb538c2a35f549b Mon Sep 17 00:00:00 2001 From: Cooldude2606 <25043174+Cooldude2606@users.noreply.github.com> Date: Sat, 25 Jul 2026 14:51:14 +0100 Subject: [PATCH] Remove unneeded comments --- packages/create/create.js | 4 ---- test/create/escape_arg.js | 3 --- 2 files changed, 7 deletions(-) diff --git a/packages/create/create.js b/packages/create/create.js index 236df97b..3d0557af 100755 --- a/packages/create/create.js +++ b/packages/create/create.js @@ -118,10 +118,6 @@ async function safeOutputFile(file, data, options={}) { } async function execFile(cmd, args) { - // Arguments are escaped here and joined into the command rather than - // passed to execFile. With shell: true it would only concatenate them by - // space without escaping anything, which is what it is deprecated for - // (DEP0190) as it gives the impression the arguments are made safe. const command = [cmd, ...args.map(escapeArg)].join(" "); logger.verbose(`executing ${command}`); return new Promise((resolve, reject) => { diff --git a/test/create/escape_arg.js b/test/create/escape_arg.js index 720fc27a..593b1a3f 100644 --- a/test/create/escape_arg.js +++ b/test/create/escape_arg.js @@ -8,9 +8,6 @@ const { escapeArg } = require("../../packages/create/escape_arg"); const execFile = util.promisify(child_process.execFile); async function exec(file, args) { - // Escape the arguments and join them into the command the same way - // create.js does, rather than passing them to execFile which would only - // concatenate them by space without escaping (DEP0190). const command = [file, ...args.map(escapeArg)].join(" "); const { stdout, stderr } = await execFile( command,