From 86a648e759ef40b3b167565726a44e697017588e Mon Sep 17 00:00:00 2001 From: Hornwitser Date: Tue, 10 Mar 2026 02:17:36 +0100 Subject: [PATCH] Detail requirements for instance waking requests These need to make sure instance status is correctly handled, otherwise they may cause the instance or host to become inoperable. --- packages/host/src/Host.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/host/src/Host.ts b/packages/host/src/Host.ts index b096a889..c3f2466e 100644 --- a/packages/host/src/Host.ts +++ b/packages/host/src/Host.ts @@ -74,7 +74,10 @@ async function discoverInstances(instancesDir: string) { return instances; } -// Requests that wake up the instance is responsible for updating the instance state in case of errors. +// Requests that wake up instances are responsible for making sure the +// instance status is correctly updated even if they fail with an error. This +// means they should typically use try catch on anything that can throw +// and call notifyExit upon any errors. const instanceStartingMessages = new Set([ lib.InstanceStartRequest.name, lib.InstanceLoadScenarioRequest.name,