From 7ba14f74330dbf13602b8b061629f9ee6db991ac Mon Sep 17 00:00:00 2001 From: Hornwitser Date: Mon, 5 Feb 2024 18:12:30 +0100 Subject: [PATCH] Fix instance details not updating on reassigmnent Always send the instance details update when an instance is reassigned, not just when it is unassigned. The idea for not sending an update when assigned to a host was that the host would send an update on the status that in turn updates the instance details. However this is not actually the case; when a stopped instance is reassigned its status does not change so the update is ignored. --- CHANGELOG.md | 1 + packages/controller/src/Controller.ts | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 68e772fe..9a507824 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ - Fixed an unhandled error in Subspace Storage crashing the host. - Fixed an unhandled rejection in disconnect logic crashing the host. +- Fixed instance screen in Web UI not updating when an instance was reassigned. ## Version 2.0.0-alpha.16 diff --git a/packages/controller/src/Controller.ts b/packages/controller/src/Controller.ts index d9a1332b..5422fedf 100644 --- a/packages/controller/src/Controller.ts +++ b/packages/controller/src/Controller.ts @@ -941,9 +941,9 @@ export default class Controller { ); } else { instance.status = "unassigned"; - instance.updatedAtMs = Date.now(); - this.instanceDetailsUpdated([instance]); } + instance.updatedAtMs = Date.now(); + this.instanceDetailsUpdated([instance]); } /**