Limit the number of subscription filters per subscriber

A subscriber could keep sending subscribe requests with new filters and
the controller would add every one of them to the subscriber's filter
set without bound, growing memory until it ran out.

Add controller.max_subscription_filters (default 10000) and reject
subscribe and replace requests that would leave a subscriber holding
more filters than that for one event.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
bbassieandClaude Opus 5.5 committed 2026-10-08 11:10:03 +00:00
1 parent ce6bfe282f
commit 690b79d2b7
5 files changed
+95 -5

No files matched your search

+8
View File
@@ -26,6 +26,7 @@ export interface ControllerConfigFields {
"controller.heartbeat_interval": number;
"controller.session_timeout": number;
"controller.metrics_timeout": number;
"controller.max_subscription_filters": number;
"controller.system_metrics_interval": number;
"controller.proxy_stream_timeout": number;
"controller.factorio_username": string | null;
@@ -208,6 +209,13 @@ export class ControllerConfig extends classes.Config<ControllerConfigFields> {
initialValue: 8,
validator: validators.greaterThanZero,
},
"controller.max_subscription_filters": {
title: "Max Subscription Filters",
description: "Maximum number of filters a single connection can hold for one subscribed event.",
type: "number",
initialValue: 10000,
validator: validators.all(validators.integer, validators.greaterThanZero),
},
"controller.system_metrics_interval": {
title: "System Metrics Interval",
description: "Interval in seconds to collect and update system metrics for the Web UI",