Fix issues detected by lgtm.com

plugins/inventory_sync/master.js

@@ -4,7 +4,6 @@ const path = require("path");
 
 const libFileOps = require("@clusterio/lib/file_ops");
 const libPlugin = require("@clusterio/lib/plugin");
-const libErrors = require("@clusterio/lib/errors");
 
 async function loadDatabase(config, logger) {
 	let itemsPath = path.resolve(config.get("master.database_directory"), "inventories.json");

plugins/player_auth/instance.js

@@ -3,7 +3,6 @@
  */
 "use strict";
 const libPlugin = require("@clusterio/lib/plugin");
-const libLuaTools = require("@clusterio/lib/lua_tools");
 
 
 class InstancePlugin extends libPlugin.BaseInstancePlugin {

plugins/player_auth/master.js

@@ -78,7 +78,7 @@ class MasterPlugin extends libPlugin.BaseMasterPlugin {
 			return;
 		}
 
-		for (let [player, entry] of this.players) {
+		for (let entry of this.players.values()) {
 			if (entry.playerCode === playerCode && entry.expires > Date.now()) {
 				let verifyCode = await generateCode(this.master.config.get("player_auth.code_length"));
 				let secret = Buffer.from(this.master.config.get("master.auth_secret"), "base64");

plugins/player_auth/web/index.jsx

@@ -1,7 +1,7 @@
 import React, { useEffect, useState } from "react";
 
 import { libPlugin } from "@clusterio/lib";
-import { notify, notifyErrorHandler } from "@clusterio/web_ui";
+import { notifyErrorHandler } from "@clusterio/web_ui";
 import { Button, Form, Input, Spin, Typography } from "antd";
 
 import "./index.css";

plugins/research_sync/instance.js

@@ -43,7 +43,7 @@ class InstancePlugin extends libPlugin.BaseInstancePlugin {
 		if (!this.syncStarted || !["starting", "running"].includes(this.instance.status)) {
 			return;
 		}
-		let { name, level, researched } = message.data;
+		let { name, level } = message.data;
 		await this.sendOrderedRcon(
 			`/sc research_sync.research_technology("${libLuaTools.escapeString(name)}", ${level})`, true
 		);

plugins/subspace_storage/dole_nn_base.js

@@ -62,7 +62,6 @@ function dose(numreq, instore, store_last_tick, dole, carry, prev_req, numreq_to
 				 debt,
 	]; // 5..12
 	let inputs = inp1.concat(inp2);
-	let internal = new Array(20).fill(0);
 	let outputs = [0, 0, 0, 0];
 	// NN: Please don't touch :), code is generated
 
@@ -78,7 +77,7 @@ function dose(numreq, instore, store_last_tick, dole, carry, prev_req, numreq_to
 		outputs[0]=1.0;
 	}
 
-	let res1 = Number(outputs[0]) * numreq+outputs[3] + debt;
+	let res1 = Number(outputs[0]) * numreq + outputs[3] + debt;
 	let res_capped = Math.round(res1);
 
 	if (res_capped > numreq) { res_capped = numreq; }
@@ -88,7 +87,7 @@ function dose(numreq, instore, store_last_tick, dole, carry, prev_req, numreq_to
 	res1 = res1 || 0;
 	res_capped = res_capped || 0; // Safeguard against wrong values
 	debt = res1 - res_capped;
-	debt_cap = Math.round(numreq * 1.5) + 5;
+	let debt_cap = Math.round(numreq * 1.5) + 5;
 	if (debt > debt_cap) {
 		debt = debt_cap;
 	}
@@ -129,7 +128,6 @@ function tick(instore, dole, store_last_tick, numreq_total_adj) {
 		store_last_tick,
 		numreq_total_adj,
 	];
-	let internal = new Array(10).fill(0);
 	let outputs = [0, 0];
 	// NN: Please don't touch :), code is generated
 
@@ -139,7 +137,7 @@ function tick(instore, dole, store_last_tick, numreq_total_adj) {
 	outputs[1] = outputs[0] * 1.828422785;
 	outputs[1] = sigmoid3(outputs[1]);
 
-	avg = outputs[1];
+	let avg = outputs[1];
 	if (numreq_total_adj < 0.11) {
 		// When no item's are requested, result is 0.1; In that case there is
 		// no deficit, so return 1 = 100% demand fulfilled

plugins/subspace_storage/instance.js

@@ -1,6 +1,4 @@
 "use strict";
-const fs = require("fs-extra");
-
 const libPlugin = require("@clusterio/lib/plugin");
 const libLuaTools = require("@clusterio/lib/lua_tools");
 

plugins/subspace_storage/routes.js

@@ -1,7 +1,4 @@
 "use strict";
-const path = require("path");
-
-
 function addApiRoutes(app, items, endpointHitCounter) {
 
 	/**