Manual adjustments to GameVersion and ReleaseChannel types

Through the creation of this commit, it was discovered that ModInfo.version must be typed as GameVersion due to file names. This results in wide spread propagation of the unsafe type.  The full impact including on ModRecord and ModVersion.testVersion have no been implemented until a path forward is decided.
This commit is contained in:
Cooldude2606 committed 2026-06-30 23:39:08 +01:00
1 parent 5d20f8fc84
commit 523293d4d9
9 files changed
+129 -88

No files matched your search

+22 -10
View File
@@ -9,12 +9,12 @@ import { ModRecord } from "./ModPack";
import {
FullVersion, integerFullVersion,
integerPartialVersion,
GameVersionSchema, normaliseGameVersion, normaliseMajorMinorVersion,
MajorMinorVersion,
MajorMinorVersion, normaliseMajorMinorVersion, integerMajorMinorVersion,
GameVersion, GameVersionSchema, normaliseGameVersion,
ModVersionEquality,
} from "./version";
type ModDependencyType = "incompatible" | "optional" | "hidden" | "unordered" | "required";
export type ModDependencyUnsatisfiedReason = "incompatible" | "missing_dependency" | "wrong_version";
@@ -132,13 +132,18 @@ export default class ModInfo {
* Version of the mod.
* Sourced from info.json.
*/
version = "0.0.0" as FullVersion;
version = "0.0.0" as GameVersion;
/**
* Type safe accessor for this.version
*/
safeVersion = "0.0.0" as FullVersion;
/**
* Integer representation of the version
*/
get integerVersion() {
return integerFullVersion(this.version);
return integerFullVersion(this.safeVersion);
}
/**
@@ -175,14 +180,19 @@ export default class ModInfo {
* Major version of Factorio this mod supports.
* Sourced from info.json.
*/
factorioVersion = "0.12" as MajorMinorVersion;
factorioVersion = "0.12" as GameVersion;
/**
* Type safe accessor for this.factorioVersion
*/
safeFactorioVersion = "0.0" as MajorMinorVersion;
/**
* Integer representation of the factorioVersion
* @type {number}
*/
get integerFactorioVersion() {
return integerPartialVersion(this.factorioVersion);
return integerMajorMinorVersion(this.safeFactorioVersion);
}
/**
@@ -221,7 +231,7 @@ export default class ModInfo {
* @param version - Mod's version
* @returns string containing {name}_{version}.zip
*/
static filename(name: string, version: FullVersion) {
static filename(name: string, version: GameVersion) {
return `${name}_${version}.zip`;
}
@@ -285,7 +295,8 @@ export default class ModInfo {
if (version === undefined) {
throw new Error(`Invalid mod version "${json.version}"`);
}
modInfo.version = version;
modInfo.version = json.version;
modInfo.safeVersion = version;
}
if (json.title) { modInfo.title = json.title; }
if (json.author) { modInfo.author = json.author; }
@@ -297,7 +308,8 @@ export default class ModInfo {
if (factorioVersion === undefined) {
throw new Error(`Invalid factorio_version "${json.factorio_version}"`);
}
modInfo.factorioVersion = normaliseMajorMinorVersion(factorioVersion);
modInfo.factorioVersion = json.factorio_version;
modInfo.safeFactorioVersion = normaliseMajorMinorVersion(factorioVersion);
}
// Parse the dependencies