mirror of
https://github.com/clusterio/clusterio.git
synced 2026-11-22 00:13:12 +09:00
Rewrote temp function to be safer, using findUnusedName
This commit is contained in:
1 parent
6910737374
commit
4f9a8fb45c
1 file changed
+5
-15
@@ -68,29 +68,19 @@ async function findUnusedName(directory, name, extension = "") {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
/**
|
|
||||||
* Returns a path to a temporary file.
|
|
||||||
*
|
|
||||||
* Warning: this function should not be relied upon to be accurate for
|
|
||||||
* security sensitive applications. The selection process is inherently
|
|
||||||
* racy and a file or folder may have been created in the folder by the time
|
|
||||||
* this function returns.
|
|
||||||
*
|
|
||||||
* @param {string} prefix - prefix for file
|
|
||||||
* @param {string} suffix - suffix for file
|
|
||||||
* @param {string} tmpdir - directory for file
|
|
||||||
*/
|
|
||||||
async function getTempFile(prefix, suffix, tmpdir) {
|
async function getTempFile(prefix, suffix, tmpdir) {
|
||||||
prefix = (typeof prefix !== "undefined") ? prefix : "tmp.";
|
prefix = (typeof prefix !== "undefined") ? prefix : "tmp.";
|
||||||
suffix = (typeof suffix !== "undefined") ? suffix : "";
|
suffix = (typeof suffix !== "undefined") ? suffix : "";
|
||||||
tmpdir = tmpdir ? tmpdir : os.tmpdir();
|
tmpdir = tmpdir ? tmpdir : os.tmpdir();
|
||||||
return path.join(tmpdir, prefix + crypto.randomBytes(16).toString("hex") + suffix);
|
let fullname = path.join(prefix + crypto.randomBytes(16).toString("hex") + suffix);
|
||||||
// IMO, 16 bytes of random hex should be fine, and hex is allowable in any filesystem, but if
|
let fullpath = path.join(tmpdir, findUnusedName(tmpdir, fullname));
|
||||||
// some other system is better, please inform
|
// If the path is not still zero, return the path, but otherwise return -1 to indicate failure
|
||||||
}
|
}
|
||||||
|
|
||||||
module.exports = {
|
module.exports = {
|
||||||
getNewestFile,
|
getNewestFile,
|
||||||
findUnusedName,
|
findUnusedName,
|
||||||
getTempFile,
|
getTempFile,
|
||||||
|
checkIfFileExists,
|
||||||
};
|
};
|
||||||
Reference in new issue
Block a user