From 4c252a07633cf3f41cfe50490a2ed4ccc0ba1394 Mon Sep 17 00:00:00 2001
From: bbassie <17990055+bbassie@users.noreply.github.com>
Date: Fri, 28 Aug 2026 10:48:54 +0000
Subject: [PATCH] Add tests for stripStaticPrefix and /api/plugins

The codecov/patch check flagged the new routes code as uncovered. The
unit tests never hit /api/plugins, so cover the static/ stripping and the
manifest error paths directly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 test/controller/routes.js | 44 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/test/controller/routes.js b/test/controller/routes.js
index 9cbbf4f8..5087e97b 100644
--- a/test/controller/routes.js
+++ b/test/controller/routes.js
@@ -73,6 +73,50 @@ describe("controller/src/routes", function() {
 			assert.equal(await responses[1].text(), "test content");
 		});
 	});
+	describe("stripStaticPrefix()", function() {
+		it("should remove a leading static/", function() {
+			assert.equal(routes.stripStaticPrefix("static/main.abc.js"), "main.abc.js");
+		});
+		it("should leave other paths alone", function() {
+			assert.equal(routes.stripStaticPrefix("main.abc.js"), "main.abc.js");
+			assert.equal(routes.stripStaticPrefix("other/static/main.js"), "other/static/main.js");
+		});
+	});
+	describe("/api/plugins", function() {
+		let endpoint;
+		beforeEach(function() {
+			endpoint = `http://localhost:${port}/api/plugins`;
+			controller.plugins = new Map([["foo", {}]]);
+			controller.mockConfigEntries.set("foo.load_plugin", true);
+		});
+		it("should strip static/ from the plugin bundle path", async function() {
+			controller.pluginInfos = [{
+				name: "foo", version: "1.0.0", npmPackage: "foo",
+				manifest: { "foo.js": "static/foo.abc.js" },
+			}];
+			let response = await fetch(endpoint);
+			assert.equal(response.status, 200);
+			assert.deepEqual(await response.json(), [{
+				name: "foo", version: "1.0.0", enabled: true, loaded: true, npmPackage: "foo",
+				web: { main: "foo.abc.js" },
+			}]);
+		});
+		it("should report missing manifest and entrypoint", async function() {
+			controller.pluginInfos = [
+				{ name: "foo", version: "1.0.0", npmPackage: "foo" },
+				{ name: "bar", version: "1.0.0", npmPackage: "bar", manifest: {} },
+				{ name: "baz", version: "1.0.0", npmPackage: "baz", manifest: { "baz.js": "remoteEntry.js" } },
+			];
+			let response = await fetch(endpoint);
+			assert.equal(response.status, 200);
+			let data = await response.json();
+			assert.equal(data[0].web.error, "Missing dist/web/manifest.json");
+			assert.equal(data[1].web.error, "Missing bar.js entry in manifest.json");
+			assert.equal(data[2].web.error, "Incompatible old remoteEntry.js entrypoint.");
+			assert.equal(data[1].loaded, false);
+			assert.equal(data[1].enabled, false);
+		});
+	});
 	describe("/api/cluster-name", function() {
 		let endpoint;
 		beforeEach(function() {