From 3ff80119e651617512a85a49cc53ee9fb6ee2f3a Mon Sep 17 00:00:00 2001 From: Cooldude2606 <25043174+Cooldude2606@users.noreply.github.com> Date: Tue, 20 May 2025 22:48:18 +0100 Subject: [PATCH] Fix flaking tests --- plugins/player_auth/test/plugin.js | 5 ++++- test/integration/clusterio.js | 5 ++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/plugins/player_auth/test/plugin.js b/plugins/player_auth/test/plugin.js index 6502bcc2..4cd2618a 100644 --- a/plugins/player_auth/test/plugin.js +++ b/plugins/player_auth/test/plugin.js @@ -286,11 +286,14 @@ describe("player_auth", function() { new SetVerifyCodeRequest("test", verify_code) ); + const user = controllerPlugin.controller.userManager.getByName("test"); + const token = controllerPlugin.controller.userManager.signUserToken(user); const verifyResult = await postJSON( `${controllerUrl}/api/player_auth/verify`, { player_code: playerCode, verify_code, verify_token } ); - assert.equal((await verifyResult.json()).verified, true); + assert.equal(verifyResult.status, 200); + assert.deepEqual(await verifyResult.json(), { verified: true, token: token }); }); }); }); diff --git a/test/integration/clusterio.js b/test/integration/clusterio.js index e4e4132d..72024886 100644 --- a/test/integration/clusterio.js +++ b/test/integration/clusterio.js @@ -707,9 +707,8 @@ describe("Integration of Clusterio", function() { for (let [, , configName, expectedResult] of testConfigs) { assert.equal(await sendRcon(44, `/config get ${configName}`), `${expectedResult}\n`); } - }); - it("should not change the instance status", async function() { - slowTest(this); + + // should not change instance status await checkInstanceStatus(44, "running"); }); it("should allow creating and removing props", async function() {