From 300db5cbfde6fca4a4063cf44d5b7c34c7471f0c Mon Sep 17 00:00:00 2001 From: Cooldude2606 <25043174+Cooldude2606@users.noreply.github.com> Date: Mon, 28 Oct 2024 17:53:37 +0000 Subject: [PATCH] Change display title for controller.external_address (#674) * Rename controller.external_address * Revert and correct title to avoid breaking change * Update change log --- CHANGELOG.md | 1 + packages/lib/src/config/definitions.ts | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 29798f73..7a37fc6b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -63,6 +63,7 @@ Many thanks to the following for contributing to this release: - Added `controller.share_factorio_credential_with_hosts` config to optionally require hosts to provide their own credentials. - Added `host.factorio_username` and `host.factorio_token` config to set Factorio credentials used on a given host. - Fixed 2.0 version extraction from linux headless downloaded during installation of clusterio. [#671](https://github.com/clusterio/clusterio/pull/671) +- Updated display name and description of `controller.external_address` to avoid confusion. [#674](https://github.com/clusterio/clusterio/pull/674) ### Breaking Changes diff --git a/packages/lib/src/config/definitions.ts b/packages/lib/src/config/definitions.ts index 132d0727..11a9dd3b 100644 --- a/packages/lib/src/config/definitions.ts +++ b/packages/lib/src/config/definitions.ts @@ -90,8 +90,8 @@ export class ControllerConfig extends classes.Config { optional: true, }, "controller.external_address": { - title: "External Address", - description: "Public facing address the controller is hosted on.", + title: "Public URL", + description: "Public facing URL the controller is hosted on, including the protocol.", type: "string", optional: true, },