From 2c9b07b8d62b6183af20fbd31bd59b04011f06be Mon Sep 17 00:00:00 2001 From: Hornwitser Date: Sat, 18 Nov 2023 22:12:14 +0100 Subject: [PATCH] Add subscription handlers in constructor Move the calls to add subscrition handlers into the constructor of Controller to reduce the amount of code in the start logic. --- packages/controller/src/Controller.ts | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/controller/src/Controller.ts b/packages/controller/src/Controller.ts index e355b836..68dba094 100644 --- a/packages/controller/src/Controller.ts +++ b/packages/controller/src/Controller.ts @@ -110,6 +110,14 @@ export default class Controller { this.wsServer = new WsServer(this); this.userManager = new UserManager(this.config); this.subscriptions = new lib.SubscriptionController(this); + + // Handle subscriptions for all internal properties + this.subscriptions.handle(lib.HostUpdateEvent); + this.subscriptions.handle(lib.InstanceDetailsUpdateEvent); + this.subscriptions.handle(lib.InstanceSaveListUpdateEvent); + this.subscriptions.handle(lib.ModPackUpdateEvent); + this.subscriptions.handle(lib.ModUpdateEvent); + this.subscriptions.handle(lib.UserUpdateEvent); } async start(args: ControllerArgs) { @@ -240,14 +248,6 @@ export default class Controller { this.app.locals.mainBundle = manifest["main.js"] || "no_web_build"; } - // Handle subscriptions for all internal properties - this.subscriptions.handle(lib.HostUpdateEvent); - this.subscriptions.handle(lib.InstanceDetailsUpdateEvent); - this.subscriptions.handle(lib.InstanceSaveListUpdateEvent); - this.subscriptions.handle(lib.ModPackUpdateEvent); - this.subscriptions.handle(lib.ModUpdateEvent); - this.subscriptions.handle(lib.UserUpdateEvent); - // Load plugins await this.loadPlugins();