Redact credentials from logged request urls (#1074)

The controller logs the url and query of every HTTP request. Plugins
doing OAuth get the authorization code as a query parameter on their
callback route, so it ended up in the log. redactUrl now accepts a
path, code joins the redacted parameter names, and redactQuery covers
the parsed query in the log metadata.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
BastiaanandClaude Opus 5.5 authored and GitHub committed 2026-10-14 15:58:00 +01:00
1 parent 2c506df38a
commit 24586a4b7c
3 files changed
+58 -12

No files matched your search

+8 -6
View File
@@ -403,16 +403,17 @@ export default class Controller {
// Log all express errors from middleware or routes (app.use is missing the type overload)
this.app.use((err: Error, req: express.Request, res: express.Response, next: express.NextFunction): void => {
const url = lib.redactUrl(req.originalUrl);
logger.log({
level: "error",
message: "Error while handling HTTP" +
`${req.httpVersion} ${req.method} ${req.originalUrl}:\n${err.stack}`,
`${req.httpVersion} ${req.method} ${url}:\n${err.stack}`,
meta: {
method: req.method,
url: req.originalUrl,
url,
httpVersion: req.httpVersion,
headers: Controller.loggableHeaders(req.headers),
query: req.query,
query: lib.redactQuery(req.query),
},
});
@@ -889,18 +890,19 @@ export default class Controller {
const endNs = process.hrtime.bigint();
const durationMs = (Number(endNs - startNs) / 1e6);
endpointDurationSummary.labels(routePath).observe(durationMs / 1e3);
const url = lib.redactUrl(req.originalUrl);
logger.log({
level: "http",
message: `HTTP${req.httpVersion} ${req.method} ${req.originalUrl}` +
message: `HTTP${req.httpVersion} ${req.method} ${url}` +
` (Status ${res.statusCode} in ${durationMs}ms)`,
meta: {
method: req.method,
url: req.originalUrl,
url,
statusCode: res.statusCode,
responseTime: durationMs,
httpVersion: req.httpVersion,
headers: Controller.loggableHeaders(req.headers),
query: req.query,
query: lib.redactQuery(req.query),
},
});
});